-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-18444 Facility Locator: add click functionality for mobile map markers #34362
base: main
Are you sure you want to change the base?
Conversation
3c33497
to
848ecec
Compare
@@ -65,17 +66,6 @@ export const ResultsList = ({ | |||
[resultsData], | |||
); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this function to a utility file as it is now shared between ResultsList
(used for desktop and the list view on mobile) and SearchResult
(used for the single listing on mobile map view)
@@ -1,55 +0,0 @@ | |||
import React from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this code into SearchResult
because it is the only place it was being used (for mobile map single listings).
} from '../actions/actionTypes'; | ||
|
||
const INITIAL_STATE = { | ||
mobileMapPinSelected: null, | ||
results: [], | ||
selectedResult: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that selectedResult
is used for whichever facility we're viewing on the Facility Locator detail page (e.g. cemetery or one of the many VBAs that isn't statically-built yet). I couldn't dual-purpose this for the mobile map selected card, unfortunately.
@@ -19,47 +19,6 @@ export const setFocus = (selector, tabIndexInclude = true) => { | |||
} | |||
}; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved these marker-related utilities to a new utility file (mapMarkers.js
)
848ecec
to
6d03d3b
Compare
6d03d3b
to
f516816
Compare
@@ -84,119 +58,7 @@ export const ResultsList = ({ | |||
*/ | |||
const renderResultItems = (searchQuery, apiResults) => { | |||
return apiResults?.map((result, index) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved the switch
statement into resultMapper.jsx
because now it needs to be shared between the regular results list and the single result shown when a mobile map pin is clicked.
Are you removing, renaming or moving a folder in this PR?
Did you change site-wide styles, platform utilities or other infrastructure?
Summary
Makes the mobile map markers in Facility Locator clickable. When clicked, the details for the facility should appear below the map and the title of the facility should be focused (yellow outline when screenreader is on).
Related issue(s)
department-of-veterans-affairs/va.gov-team#0000
department-of-veterans-affairs/vets-website#0000
department-of-veterans-affairs/va.gov-team#0000
Testing done
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?