Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

98864 - adds location and type of care to patient relationships #34185

Conversation

ryanshaw
Copy link
Contributor

@ryanshaw ryanshaw commented Jan 22, 2025

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

This adds the ability for arguments to be passed via the patient relationships endpoint GET request

Related issue(s)

department-of-veterans-affairs/va.gov-team#98864

Testing done

  • Local testing
  • Updated unit tests

What areas of the site does it impact?

VAOS mocks and patient services

Acceptance criteria

Quality Assurance & Testing

  • I updated unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@ryanshaw ryanshaw self-assigned this Jan 22, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to master/ryanshaw/98864/adds-location-and-type-of-care-to-patient-relationships/main January 22, 2025 00:15 Inactive
…-website into ryanshaw/98864/adds-location-and-type-of-care-to-patient-relationships
@ryanshaw ryanshaw merged commit 761bf38 into main Jan 22, 2025
85 checks passed
@ryanshaw ryanshaw deleted the ryanshaw/98864/adds-location-and-type-of-care-to-patient-relationships branch January 22, 2025 17:36
tynyttie pushed a commit that referenced this pull request Jan 24, 2025
* Updates patient relationship service to accept args

Signed-off-by: Ryan Shaw <[email protected]>

* Adds hasAvailability attribute to patient relationships

Signed-off-by: Ryan Shaw <[email protected]>

---------

Signed-off-by: Ryan Shaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants