Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVA-1575: Clicking back on flow 1d fix #34131

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

hemeshvpatel
Copy link
Contributor

@hemeshvpatel hemeshvpatel commented Jan 16, 2025

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Fix back button issue in flow
  • Remove unused code (refactor custom pages in form schema imports)
  • The Ask VA team owns this

Related issue(s)

Testing done

  • Manual testing of flow

Screenshots

  • no UI changes

What areas of the site does it impact?

  • This only impacts the Ask VA form

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@hemeshvpatel hemeshvpatel self-assigned this Jan 16, 2025
@hemeshvpatel hemeshvpatel changed the title fix flow back issue, remove unused code AVA-1575: Clicking back on flow 1d fix Jan 16, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to master/AVA-1575--Clicking-back-on-1d-fix/main January 16, 2025 19:27 Inactive
Copy link
Contributor

@ediiotero ediiotero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@hemeshvpatel hemeshvpatel marked this pull request as ready for review January 16, 2025 19:46
@hemeshvpatel hemeshvpatel requested review from a team as code owners January 16, 2025 19:46
@va-vfs-bot va-vfs-bot temporarily deployed to master/AVA-1575--Clicking-back-on-1d-fix/main January 16, 2025 20:19 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/AVA-1575--Clicking-back-on-1d-fix/main January 16, 2025 23:14 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/AVA-1575--Clicking-back-on-1d-fix/main January 17, 2025 15:57 Inactive
@hemeshvpatel hemeshvpatel merged commit 0d62115 into main Jan 17, 2025
68 checks passed
@hemeshvpatel hemeshvpatel deleted the AVA-1575--Clicking-back-on-1d-fix branch January 17, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants