Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AskVA 1348 - Fix ask-va url to remove too #34097

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

hemeshvpatel
Copy link
Contributor

@hemeshvpatel hemeshvpatel commented Jan 15, 2025

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Prep ask va folder to remove the 'too' from the url and app name
  • We have PRs in content build, vets-api, and vsp reverse proxy already
  • The Ask VA team owns this and it is part of our POC

Related issue(s)

Testing done

  • n/a

Screenshots

  • n/a

What areas of the site does it impact?

  • This only impacts the Ask VA form

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@hemeshvpatel hemeshvpatel self-assigned this Jan 15, 2025
@hemeshvpatel hemeshvpatel marked this pull request as ready for review January 15, 2025 00:46
@hemeshvpatel hemeshvpatel requested review from a team as code owners January 15, 2025 00:46
Copy link
Contributor

@joehall-tw joehall-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Appreciate you for updating the Cypress stuff too.

@Andrew565
Copy link
Contributor

PR has failing tests, choosing not to review at this time - T2 FE Support

@va-vfs-bot va-vfs-bot temporarily deployed to master/Ask-VA-1348--Remove-too-from-ask-va/main January 15, 2025 15:04 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/Ask-VA-1348--Remove-too-from-ask-va/main January 15, 2025 16:05 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants