Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travel Pay / add content to review page & unsupported claim type page #34044

Draft
wants to merge 60 commits into
base: main
Choose a base branch
from

Conversation

liztownd
Copy link
Contributor

@liztownd liztownd commented Jan 13, 2025

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • (Summarize the changes that have been made to the platform)

    • Adding content/functionality to Review Page and Unsupported Claim Type (Can't File) Page
    • Update related tests
  • (Which team do you work for, does your team own the maintenance of this component?)
    Travel Pay

  • (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

  • Currently behind flipper, phased rollout begins Feb 1

Related issue(s)

Testing done

  • Describe what the old behavior was prior to the change

  • Pages were shells, added content to 2 pages + functionality, updated Unit tests and cypress test

  • Describe the steps required to verify your changes are working as expected
    Visit my-health/travel-pay/file-new-claim/{any made up ID} and move through the flow (answering no to one question to verify the Unsupported Claim Type page has content, then go back to the question and answer yes). On the review page you must select "agree" to the travel agreement before hitting the "File claim" button.

  • Describe the tests completed and the results
    Unit tests for each page updated.

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile - Unsupported Unsupported-old Unsupported-mobile
Desktop - Unsupported Unsupported-old-desk Unsupported desktop
Mobile - Review review-mobile-old review-mobile
Desktop - Review review-old review-desktop
Mobile - Agreement N/A travel agreement mobile
Desktop - Agreement N/A travel agreement

What areas of the site does it impact?

Travel Pay

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

liztownd and others added 30 commits January 2, 2025 15:14
@va-vfs-bot va-vfs-bot temporarily deployed to master/liz/flesh-out-review-page/main January 13, 2025 17:43 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants