Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travel Pay / flesh out SMOC introduction page #33888

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

liztownd
Copy link
Contributor

@liztownd liztownd commented Jan 3, 2025

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • (Summarize the changes that have been made to the platform)
    Add content to Introduction page; refactor Help Text and update where it was used; add mock data for user + appointment

  • (Which team do you work for, does your team own the maintenance of this component?)
    Travel Pay

  • (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

  • Phased rollout beginning Feb 2025

Related issue(s)

Testing done

  • Describe what the old behavior was prior to the change
    The Introduction page for our submit mileage claim form flow was a shell, now it has data (hardcoded) and content.
  • Describe the steps required to verify your changes are working as expected
    Locally: Start the mock api with yarn mock-api --responses src/applications/travel-pay/services/mocks/index.js; Build locally with yarn build:webpack:local --env api="http://localhost:3000" then serve the build with WEB_PORT=3001 node src/platform/testing/e2e/test-server.js --buildtype=localhost (instructions in README).
  • Describe the tests completed and the results
    New Cypress test to test the flow through the form; New unit tests to verify each component including the new Introduction Page component.

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile Intro mobile old Intro mobile new
Desktop Intro page old Intro page new

What areas of the site does it impact?

Travel Pay directory only

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/liz/flesh-out-intro-page/main January 3, 2025 21:51 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/liz/flesh-out-intro-page/main January 3, 2025 22:12 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/liz/flesh-out-intro-page/main January 6, 2025 13:14 Inactive
seesleestak
seesleestak previously approved these changes Jan 6, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to master/liz/flesh-out-intro-page/main January 7, 2025 13:27 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/liz/flesh-out-intro-page/main January 7, 2025 13:46 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/liz/flesh-out-intro-page/main January 7, 2025 14:05 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/liz/flesh-out-intro-page/main January 7, 2025 14:24 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/liz/flesh-out-intro-page/main January 7, 2025 15:35 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/liz/flesh-out-intro-page/main January 7, 2025 16:06 Inactive
Copy link

@seesleestak seesleestak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well for me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants