-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travel Pay / flesh out SMOC introduction page #33888
Draft
liztownd
wants to merge
34
commits into
main
Choose a base branch
from
liz/flesh-out-intro-page
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,163
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/liz/flesh-out-intro-page/main
January 3, 2025 21:51
Inactive
va-vfs-bot
temporarily deployed
to
master/liz/flesh-out-intro-page/main
January 3, 2025 22:12
Inactive
va-vfs-bot
temporarily deployed
to
master/liz/flesh-out-intro-page/main
January 6, 2025 13:14
Inactive
seesleestak
previously approved these changes
Jan 6, 2025
va-vfs-bot
temporarily deployed
to
master/liz/flesh-out-intro-page/main
January 7, 2025 13:27
Inactive
va-vfs-bot
temporarily deployed
to
master/liz/flesh-out-intro-page/main
January 7, 2025 13:46
Inactive
va-vfs-bot
temporarily deployed
to
master/liz/flesh-out-intro-page/main
January 7, 2025 14:05
Inactive
va-vfs-bot
temporarily deployed
to
master/liz/flesh-out-intro-page/main
January 7, 2025 14:24
Inactive
va-vfs-bot
temporarily deployed
to
master/liz/flesh-out-intro-page/main
January 7, 2025 15:35
Inactive
va-vfs-bot
temporarily deployed
to
master/liz/flesh-out-intro-page/main
January 7, 2025 16:06
Inactive
seesleestak
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well for me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you removing, renaming or moving a folder in this PR?
Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the
#sitewide-public-websites
Slack channel for questions.Did you change site-wide styles, platform utilities or other infrastructure?
Summary
(Summarize the changes that have been made to the platform)
Add content to Introduction page; refactor Help Text and update where it was used; add mock data for user + appointment
(Which team do you work for, does your team own the maintenance of this component?)
Travel Pay
(If using a flipper, what is the end date of the flipper being required/success criteria being targeted)
Phased rollout beginning Feb 2025
Related issue(s)
Link to ticket created in va.gov-team repo
#92353
#10016
#10015
Link to epic if not included in ticket
#83829
Testing done
The Introduction page for our submit mileage claim form flow was a shell, now it has data (hardcoded) and content.
Locally: Start the mock api with
yarn mock-api --responses src/applications/travel-pay/services/mocks/index.js
; Build locally withyarn build:webpack:local --env api="http://localhost:3000"
then serve the build withWEB_PORT=3001 node src/platform/testing/e2e/test-server.js --buildtype=localhost
(instructions in README).New Cypress test to test the flow through the form; New unit tests to verify each component including the new Introduction Page component.
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
Travel Pay directory only
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?