Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix required span font size #33814

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Fix required span font size #33814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import { useHistory } from 'react-router-dom';
import { shallowEqual, useDispatch, useSelector } from 'react-redux';
import PropTypes from 'prop-types';
import moment from 'moment';

Check warning on line 5 in src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx:5:1:Use date-fns or Native Date methods instead of moment.js
import FormButtons from '../../components/FormButtons';
import { scrollAndFocus } from '../../utils/scrollAndFocus';
import CalendarWidget from '../../components/calendar/CalendarWidget';
Expand Down Expand Up @@ -106,10 +106,10 @@
useEffect(() => {
dispatch(
getAppointmentSlots(
moment()

Check warning on line 109 in src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx:109:9:Consider using date-fns startOfMonth(date) or dayjs().startOf(unit)

Check warning on line 109 in src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx:109:9:Consider using Native new Date().
.startOf('month')
.format('YYYY-MM-DD'),
moment()

Check warning on line 112 in src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx:112:9:Consider using date-fns addDays(date, amount) or dayjs().add(number, unit)

Check warning on line 112 in src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx:112:9:Consider using Native new Date().
.add(1, 'months')
.endOf('month')
.format('YYYY-MM-DD'),
Expand All @@ -120,7 +120,7 @@
if (featureBreadcrumbUrlUpdate) {
changeCrumb(pageTitle);
}
}, []);

Check warning on line 123 in src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx:123:6:React Hook useEffect has missing dependencies: 'changeCrumb', 'dispatch', and 'featureBreadcrumbUrlUpdate'. Either include them or remove the dependency array. If 'changeCrumb' changes too often, find the parent component that defines it and wrap that definition in useCallback.

useEffect(
() => {
Expand All @@ -139,7 +139,7 @@
},
// Intentionally leaving isInitialLoad off, because it should trigger updates, it just
// determines which update is made
[loadingSlots, appointmentSlotsStatus],

Check warning on line 142 in src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx:142:5:React Hook useEffect has a missing dependency: 'isInitialLoad'. Either include it or remove the dependency array.
);

useEffect(
Expand All @@ -155,7 +155,7 @@
<div>
<h1 className="vads-u-font-size--h2">
{pageTitle}
<span className="schemaform-required-span vaos-calendar__page_header vads-u-font-size--base vads-u-font-family--sans vads-u-font-weight--normal">
<span className="schemaform-required-span vaos-calendar__page_header vads-u-font-family--sans vads-u-font-weight--normal">
(*Required)
</span>
</h1>
Expand Down Expand Up @@ -186,7 +186,7 @@
timezone={timezone}
disabled={loadingSlots}
disabledMessage={
<va-loading-indicator

Check warning on line 189 in src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx:189:15:Missing parentheses around multilines JSX
data-testid="loadingIndicator"
set-focus
message="Finding appointment availability..."
Expand All @@ -200,7 +200,7 @@
onPreviousMonth={(...args) =>
dispatch(getAppointmentSlots(...args))
}
minDate={moment()

Check warning on line 203 in src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx:203:22:Consider using date-fns addDays(date, amount) or dayjs().add(number, unit)

Check warning on line 203 in src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/vaos/covid-19-vaccine/components/SelectDate1Page.jsx:203:22:Consider using Native new Date().
.add(1, 'days')
.format('YYYY-MM-DD')}
maxDate={moment()
Expand Down
2 changes: 1 addition & 1 deletion src/applications/vaos/new-appointment/components/DateTimeRequestPage/VA.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export default function VARequest({ changeCrumb }) {
<div className="vaos-form__detailed-radio">
<h1 className="vads-u-font-size--h2">
{pageTitle}
<span className="schemaform-required-span vaos-calendar__page_header vads-u-font-size--base vads-u-font-family--sans vads-u-font-weight--normal">
<span className="schemaform-required-span vaos-calendar__page_header vads-u-font-family--sans vads-u-font-weight--normal">
(*Required)
</span>
</h1>
Expand Down
2 changes: 1 addition & 1 deletion src/applications/vaos/new-appointment/components/TypeOfCarePage/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export default function TypeOfCarePage() {
<div className="vaos-form__radio-field">
<h1 className="vads-u-font-size--h2">
{pageTitle}
<span className="schemaform-required-span vads-u-font-size--base vads-u-font-family--sans vads-u-font-weight--normal">
<span className="schemaform-required-span vads-u-font-family--sans vads-u-font-weight--normal">
(*Required)
</span>
</h1>
Expand Down
1 change: 1 addition & 0 deletions src/applications/vaos/sass/vaos.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ va-radio::part(legend) {
margin-top: 16px;
}

.schemaform-required-span,
body {
font-size: 1.06rem; // same as 16.96px
}
Loading