Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDP] 94725 - Alert content updates #33810

Merged
merged 5 commits into from
Dec 31, 2024
Merged

Conversation

Dr-Pongo
Copy link
Contributor

@Dr-Pongo Dr-Pongo commented Dec 30, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

  • No

Summary

Updating alerts to match new content which includes more clear language on who to contact at VA.

Related issue(s)

Testing done

WIP

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

Overview Page Overview page at `manage-va-debt/summary`
Before After
Both endpoints fail image image
Debts fail image image
Copays fail image image
Debt summary page Overview page at `manage-va-debt/summary/debt-balances`
Before After
Both endpoints fail image image
Debts fail, copays available image image
Debts fail, no copays image image
Other VA section - Copay error image image
Copay summary page Overview page at `manage-va-debt/summary/copay-balances`
Before After
Both endpoints fail image image
Copays fail, debts available image image
Copays fail, no debts image image
Other VA section - debt error image image

What areas of the site does it impact?

CDP Alert messages only
(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Copy link
Contributor

@OptionSelect OptionSelect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link

@mgleo mgleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Dr-Pongo Dr-Pongo marked this pull request as ready for review December 31, 2024 15:21
@Dr-Pongo Dr-Pongo requested review from a team as code owners December 31, 2024 15:21
@Dr-Pongo Dr-Pongo merged commit c3a24b1 into main Dec 31, 2024
85 checks passed
@Dr-Pongo Dr-Pongo deleted the cdp/feature/94725/alert-updates branch December 31, 2024 19:03
@Dr-Pongo Dr-Pongo changed the title [CDP] Alert content updates [CDP] 94725 - Alert content updates Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants