-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBEX 0781 consent page #33804
base: main
Are you sure you want to change the base?
DBEX 0781 consent page #33804
Conversation
src/applications/disability-benefits/all-claims/content/form0781/consentPage.jsx
Outdated
Show resolved
Hide resolved
src/applications/disability-benefits/all-claims/content/form0781/consentPage.jsx
Outdated
Show resolved
Hide resolved
src/applications/disability-benefits/all-claims/content/form0781/consentPage.jsx
Outdated
Show resolved
Hide resolved
src/applications/disability-benefits/all-claims/pages/form0781/consentPage.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions to consider, otherwise looks great.
Co-authored-by: Scott Regenthal <[email protected]>
export function isRelatedToMST(formData) { | ||
return ( | ||
isCompletingForm0781(formData) && | ||
formData.mentalHealth.eventTypes.mst === true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously overlooked that optional chaining should be added here to avoid throwing a TypeError, in the event a property is null or undefined.
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Are you removing, renaming or moving a folder in this PR?
If the folder you changed contains a
manifest.json
, search for itsentryName
in the content-build registry.json (theentryName
there will match).If an entry for this folder exists in content-build and you are:
Deleting a folder:
vets-website
for all instances of theentryName
in yourmanifest.json
and remove them in a separate PR. Look particularly for references insrc/applications/static-pages/static-pages-entry.js
andsrc/platform/forms/constants.js
. If you do not do this, other applications will break!Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).
Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the
#sitewide-public-websites
Slack channel for questions.Did you change site-wide styles, platform utilities or other infrastructure?
Summary
(Summarize the changes that have been made to the platform)
(If bug, how to reproduce)
(What is the solution, why is this the solution)
(Which team do you work for, does your team own the maintenance of this component?)
(If using a flipper, what is the end date of the flipper being required/success criteria being targeted)
sync_modern_0781_flow
will be utilized for specific users until all who start a new form and claim a new disability will be routed through an alternative 0781 flowRelated issue(s)
Consent Page Skeleton [0781 PS] (8) Consent Page Skeleton va.gov-team#97084
Consent Page Content [0781 PS] (9) Consent Page Content va.gov-team#97871
Testing done
N/A - This is a new step in the digital form
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?