Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS 20190 - fix zips without bbox #33785

Merged
merged 5 commits into from
Jan 2, 2025
Merged

VACMS 20190 - fix zips without bbox #33785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
37e15d2
fix zips without bbox
eselkin Dec 27, 2024
d6b0683
tests passing
eselkin Dec 27, 2024
d532155
Merge branch 'main' into VACMS-20190-some-zip-codes-crash-FL
eselkin Dec 27, 2024
cadecac
Merge branch 'main' into VACMS-20190-some-zip-codes-crash-FL
eselkin Dec 30, 2024
39b8dec
Merge branch 'main' into VACMS-20190-some-zip-codes-crash-FL
eselkin Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/applications/facility-locator/actions/mapbox/genBBoxFromAddress.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,9 @@ export const genBBoxFromAddress = (query, expandedRadius = false) => {
];
}
const radius = radiusFromBoundingBox(
features,
features?.[0]?.bbox
? features
: [{ ...features[0], bbox: minBounds }],
query?.facilityType === 'provider',
);
dispatch({
Expand Down
2 changes: 1 addition & 1 deletion src/applications/facility-locator/tests/e2e/map-zoom.cypress.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
const clickInterval = 10;

// Zoom in
[...Array(5)].forEach(_ =>
[...Array(15)].forEach(_ =>
// eslint-disable-next-line cypress/no-unnecessary-waiting
cy

Check warning on line 9 in src/applications/facility-locator/tests/e2e/map-zoom.cypress.spec.js

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/facility-locator/tests/e2e/map-zoom.cypress.spec.js:9:5:It is unsafe to chain further commands that rely on the subject after this command. It is best to split the chain, chaining again from `cy.` in a next command line.
.get('.mapboxgl-ctrl-zoom-in')
.click({ waitForAnimations: true })
.wait(clickInterval),
Expand All @@ -18,7 +18,7 @@
// Zoom out
[...Array(13)].forEach(_ =>
// eslint-disable-next-line cypress/no-unnecessary-waiting
cy

Check warning on line 21 in src/applications/facility-locator/tests/e2e/map-zoom.cypress.spec.js

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/facility-locator/tests/e2e/map-zoom.cypress.spec.js:21:5:It is unsafe to chain further commands that rely on the subject after this command. It is best to split the chain, chaining again from `cy.` in a next command line.
.get('.mapboxgl-ctrl-zoom-out')
.click({ waitForAnimations: true })
.wait(clickInterval),
Expand All @@ -30,7 +30,7 @@
// Zoom in again
[...Array(12)].forEach(_ =>
// eslint-disable-next-line cypress/no-unnecessary-waiting
cy

Check warning on line 33 in src/applications/facility-locator/tests/e2e/map-zoom.cypress.spec.js

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/facility-locator/tests/e2e/map-zoom.cypress.spec.js:33:5:It is unsafe to chain further commands that rely on the subject after this command. It is best to split the chain, chaining again from `cy.` in a next command line.
.get('.mapboxgl-ctrl-zoom-in')
.click({ waitForAnimations: true })
.wait(clickInterval),
Expand Down Expand Up @@ -67,7 +67,7 @@
.shadow()
.find('select')
.select('VA health');
cy.get('#facility-search')

Check warning on line 70 in src/applications/facility-locator/tests/e2e/map-zoom.cypress.spec.js

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/facility-locator/tests/e2e/map-zoom.cypress.spec.js:70:3:It is unsafe to chain further commands that rely on the subject after this command. It is best to split the chain, chaining again from `cy.` in a next command line.
.click({ force: true })
.then(() => {
cy.get('#search-results-subheader').contains(
Expand Down
Loading