Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS - 19549 19800 conditional render services select, and loading indicator until CCP services loaded #33784

Open
wants to merge 12 commits into
base: VACMS-19548-orientation-of-map-controls-fl
Choose a base branch
from

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Dec 27, 2024

**Merges into the integration branch for map control changes - for review **

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Make services render conditionally and add loading indicator until CCP services are loaded
  • Sitewide team - we manage the Facility Locator

Related issue(s)

Testing done

  • Prior to change, services would always appear for all facilities (including when a facility type was not selected). Make sure it only appears when one is selected. Also when CCP is selected, because of it's dependence on a initial call to PPMS, we make make sure the typeahead only displays when the services have been downloaded. In the interim of CCP selection, show loading indicaor.
  • Manually tested

Screenshots

Video with all the options selected on Tablet and Small Desktop and Mobile Sizes

video1572992751.mp4

What areas of the site does it impact?

Facility Locator

Acceptance criteria

#19549

  • These Facility Types result in display of "Service type":
    • VA health
    • Urgent care
    • Emergency care
    • Community providers (in VA's network)
  • These facility types that NO NOT result in display of "Service type":
    • Community Pharmacies (in VA's network)
    • VA Benefits
    • VA cemeteries
    • Vet Centers
  • Ensure that any existing analytics are ported over (no change in analytics)

#19800

  • When user selects Community Providers in facility type, the service selector box does not immediately appear
  • In its place, a loading animation displays and persists until PPMS data is loaded
  • When PPMS data loads, animation is replaced by the services selector

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

Check all conditions on the RI from the video

@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19549-conditional-render-services-select-fl/main December 27, 2024 22:59 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19549-conditional-render-services-select-fl/main December 28, 2024 00:15 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19549-conditional-render-services-select-fl/main December 30, 2024 22:59 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19549-conditional-render-services-select-fl/main January 2, 2025 16:55 Inactive
@eselkin eselkin marked this pull request as ready for review January 2, 2025 18:03
@eselkin eselkin requested review from a team as code owners January 2, 2025 18:03
Copy link

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

default:
break;
}
// eslint-disable-next-line consistent-return

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

ignore = true;
};
},
// eslint-disable-next-line react-hooks/exhaustive-deps

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19549-conditional-render-services-select-fl/main January 2, 2025 18:08 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants