-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS - 19549 19800 conditional render services select, and loading indicator until CCP services loaded #33784
base: VACMS-19548-orientation-of-map-controls-fl
Are you sure you want to change the base?
Conversation
…19549-conditional-render-services-select-fl
…19549-conditional-render-services-select-fl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint is disabled
vets-website
uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.
What you can do
See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.
default: | ||
break; | ||
} | ||
// eslint-disable-next-line consistent-return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint disabled here
ignore = true; | ||
}; | ||
}, | ||
// eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint disabled here
…19549-conditional-render-services-select-fl
**Merges into the integration branch for map control changes - for review **
Are you removing, renaming or moving a folder in this PR?
Did you change site-wide styles, platform utilities or other infrastructure?
Summary
Related issue(s)
Testing done
Screenshots
Video with all the options selected on Tablet and Small Desktop and Mobile Sizes
video1572992751.mp4
What areas of the site does it impact?
Facility Locator
Acceptance criteria
#19549
#19800
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
Check all conditions on the RI from the video