Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form 10282 e2e test #33782

Merged
merged 8 commits into from
Jan 9, 2025
Merged

Form 10282 e2e test #33782

merged 8 commits into from
Jan 9, 2025

Conversation

GovCIOLiz
Copy link
Contributor

@GovCIOLiz GovCIOLiz commented Dec 27, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)

Summary

  • Uncommenting keyboard-only e2e test for form 10282 now that BE code on staging

Related issue(s)

Form 10282 work. Form lives on staging only.

Testing done

  • Updated and ran successfully
Screenshot 2024-12-27 at 10 53 03 AM

What areas of the site does it impact?

Form 10282 work. Form lives on staging only.

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/10282E2E/main December 27, 2024 18:46 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/10282E2E/main December 27, 2024 19:39 Inactive
@GovCIOLiz GovCIOLiz marked this pull request as ready for review December 27, 2024 20:41
@GovCIOLiz GovCIOLiz requested review from a team as code owners December 27, 2024 20:41
@va-vfs-bot va-vfs-bot temporarily deployed to master/10282E2E/main December 29, 2024 20:13 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/10282E2E/main December 29, 2024 20:38 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/10282E2E/main December 29, 2024 23:18 Inactive
@GovCIOLiz GovCIOLiz merged commit 04d8cc6 into main Jan 9, 2025
80 checks passed
@GovCIOLiz GovCIOLiz deleted the 10282E2E branch January 9, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants