Art/97602/arp header2 #33779
Closed
Art/97602/arp header2 #33779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
reviewed
Dec 27, 2024
There was a problem hiding this comment.
Icon found
Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.
What you can do
Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.
Note:
Font Awesome is deprecated. Please use va-icon instead. For more information, visit the migration documentation: Migrate from font awesome to va-icon
| type="button" | ||
| > | ||
| {btnText} | ||
| <va-icon |
| /> | ||
| <span data-testid={dataTestId}>{name}</span> | ||
| {secondaryIcon && ( | ||
| <va-icon |
va-vfs-bot
reviewed
Dec 27, 2024
| ); | ||
| return ( | ||
| <div className="va-dropdown" ref={dropdownRef}> | ||
| {/* eslint-disable-next-line @department-of-veterans-affairs/prefer-button-component */} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.