Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDP] Updated VHA card to match VBA #33774

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

josephrlee
Copy link
Contributor

@josephrlee josephrlee commented Dec 27, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Updated heading structure to match VBA
  • Updated custom Link to VALink
  • Simplified current and past due copy

Related issue(s)

Testing done

  • Tested locally

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile localhost_3001_manage-va-debt_summary_copay-balances (3) localhost_3001_manage-va-debt_summary_copay-balances (4)
Desktop localhost_3001_manage-va-debt_summary_copay-balances (2) localhost_3001_manage-va-debt_summary_copay-balances (1)

What areas of the site does it impact?

Combined debt portal

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

- Changed heading structure
- Updated custom link to VALink
- Simplified current and past due copy
@josephrlee josephrlee linked an issue Dec 27, 2024 that may be closed by this pull request
11 tasks
@josephrlee josephrlee marked this pull request as ready for review December 27, 2024 19:52
@josephrlee josephrlee requested review from a team as code owners December 27, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CDP] VHA - Update cards
2 participants