Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form 10215 Updates #33771

Merged
merged 9 commits into from
Dec 30, 2024
Merged

Form 10215 Updates #33771

merged 9 commits into from
Dec 30, 2024

Conversation

GovCIOLiz
Copy link
Contributor

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)

Summary

  • Custom text for review page submit button to say "Continue"
  • Logic to make sure calculations on the program form page are updating from edit mode with array builder pattern
  • Fix spelling error

Related issue(s)

  • VEBT-847

Testing done

Screenshots

UI the same

What areas of the site does it impact?

Form 10215 - WIP - staging only

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@GovCIOLiz GovCIOLiz marked this pull request as ready for review December 27, 2024 14:52
@GovCIOLiz GovCIOLiz requested review from a team as code owners December 27, 2024 14:52
@va-vfs-bot va-vfs-bot temporarily deployed to master/10215Edits/main December 27, 2024 21:05 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/10215Edits/main December 27, 2024 21:26 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/10215Edits/main December 27, 2024 22:25 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/10215Edits/main December 30, 2024 15:06 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/10215Edits/main December 30, 2024 15:14 Inactive
@GovCIOLiz GovCIOLiz merged commit 0f7f93e into main Dec 30, 2024
80 checks passed
@GovCIOLiz GovCIOLiz deleted the 10215Edits branch December 30, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants