Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/extend Form Upload testing #33747

Merged
merged 6 commits into from
Jan 2, 2025
Merged

Improve/extend Form Upload testing #33747

merged 6 commits into from
Jan 2, 2025

Conversation

Thrillberg
Copy link
Contributor

@Thrillberg Thrillberg commented Dec 23, 2024

Summary

This PR aims to improve our testing of the Form Upload app.

Related issue(s)

https://github.com/orgs/department-of-veterans-affairs/projects/1443/views/3?sliceBy%5Bvalue%5D=Thrillberg&pane=issue&itemId=90877603&issue=department-of-veterans-affairs%7CVA.gov-team-forms%7C1919

Testing done

image

Screenshots

Before:
Screenshot 2024-12-23 at 12 33 18 PM

WIP 1:
Screenshot 2024-12-23 at 12 31 57 PM

WIP 2:
Screenshot 2024-12-23 at 3 29 29 PM

DONE:
Screenshot 2024-12-24 at 10 16 27 AM

@va-vfs-bot va-vfs-bot temporarily deployed to master/form-upload-testing/main December 23, 2024 20:35 Inactive
@Thrillberg Thrillberg marked this pull request as ready for review December 24, 2024 15:17
@Thrillberg Thrillberg requested review from a team as code owners December 24, 2024 15:17
@va-vfs-bot va-vfs-bot temporarily deployed to master/form-upload-testing/main December 24, 2024 15:17 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/form-upload-testing/main January 2, 2025 15:41 Inactive
Copy link
Contributor

@pennja pennja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great work! 👍

@Thrillberg Thrillberg merged commit 34dedc1 into main Jan 2, 2025
79 checks passed
@Thrillberg Thrillberg deleted the form-upload-testing branch January 2, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants