Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS - detail pages needed to alter columns and margin to fit on same row due to gutter changes #33740

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Dec 21, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Changes 8 to 7 column width for left side of detail page and adds margin to make sure
  • Sitewide team, we own the Facility Locator app with the detail pages

Related issue(s)

Testing done

  • Tested manually

Screenshots

Before - desktop (on va.gov) Screenshot 2024-12-20 at 4 00 27 PM
Before - tablet (on va.gov) Screenshot 2024-12-20 at 4 01 06 PM
new on desktop Screenshot 2024-12-20 at 4 00 41 PM
new on tablet Screenshot 2024-12-20 at 4 00 50 PM

What areas of the site does it impact?

Facility locator detail pages

Acceptance criteria

Hours and Detail information appear in one row

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

Test:
find-locations/facility/nca_898
or
/find-locations/facility/vba_328c

@eselkin
Copy link
Contributor Author

eselkin commented Dec 21, 2024

The CI error is some other team's error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants