-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vebt-889: CT Redesign - Homepage #33623
Open
fatmakhan0395
wants to merge
11
commits into
main
Choose a base branch
from
vebt-889-ct-redesign-homepage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+379
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/vebt-889-ct-redesign-homepage/main
December 17, 2024 16:42
Inactive
GovCIOLiz
reviewed
Dec 17, 2024
va-vfs-bot
temporarily deployed
to
master/vebt-889-ct-redesign-homepage/main
December 18, 2024 07:13
Inactive
va-vfs-bot
temporarily deployed
to
master/vebt-889-ct-redesign-homepage/main
December 18, 2024 17:20
Inactive
va-vfs-bot
temporarily deployed
to
master/vebt-889-ct-redesign-homepage/main
December 18, 2024 17:48
Inactive
va-vfs-bot
temporarily deployed
to
master/vebt-889-ct-redesign-homepage/main
December 19, 2024 01:21
Inactive
va-vfs-bot
temporarily deployed
to
master/vebt-889-ct-redesign-homepage/main
December 20, 2024 11:08
Inactive
va-vfs-bot
temporarily deployed
to
master/vebt-889-ct-redesign-homepage/main
December 23, 2024 15:04
Inactive
GovCIOLiz
previously approved these changes
Dec 23, 2024
va-vfs-bot
temporarily deployed
to
master/vebt-889-ct-redesign-homepage/main
December 23, 2024 16:52
Inactive
va-vfs-bot
temporarily deployed
to
master/vebt-889-ct-redesign-homepage/main
December 23, 2024 21:38
Inactive
va-vfs-bot
temporarily deployed
to
master/vebt-889-ct-redesign-homepage/main
December 26, 2024 18:24
Inactive
GovCIOLiz
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Are you removing, renaming or moving a folder in this PR?
If the folder you changed contains a
manifest.json
, search for itsentryName
in the content-build registry.json (theentryName
there will match).If an entry for this folder exists in content-build and you are:
Deleting a folder:
vets-website
for all instances of theentryName
in yourmanifest.json
and remove them in a separate PR. Look particularly for references insrc/applications/static-pages/static-pages-entry.js
andsrc/platform/forms/constants.js
. If you do not do this, other applications will break!Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).
Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the
#sitewide-public-websites
Slack channel for questions.Did you change site-wide styles, platform utilities or other infrastructure?
Summary
Created homepage for new design of CT
Added feature toggle
-Added cypress and unit tests
(Summarize the changes that have been made to the platform)
(If bug, how to reproduce)
(What is the solution, why is this the solution)
(Which team do you work for, does your team own the maintenance of this component?)
(If using a flipper, what is the end date of the flipper being required/success criteria being targeted)
Related issue(s)
As a...
VEBT Developer
I want…
To build the CT homepage redesign initial page
So that…
FE CT redesign work can start
Acceptance Criteria
Header -> GI Bill® Comparison Tool
Text -> Discover how your GI Bill benefits can support your education. Search and compare approved schools, employers, exams, licenses, and certifications to see how much your VA benefits can help cover.
3 hyperlinks -> (view image attached)
Schools and employers
Search and compare public and private schools. Filter by on-the-job training, apprenticeships, and more.
Licenses and certifications
Search for licenses, certifications, and prep courses. You can submit a form to get reimbursed.
National Exams
Take national exams such as SAT, ACT, GRE, GMAT, and more. You can submit a form to get reimbursed.
Technical Details:
Dependencies:
We are going to need to collaborate with EDM to point 2 sections to the EDM work
Collaborate with EDM to utilize one feature toggle
Feature Flag needed: Yes
Demo needed: Yes
UAT needed: Yes
department-of-veterans-affairs/va.gov-team#0000
department-of-veterans-affairs/vets-website#0000
department-of-veterans-affairs/va.gov-team#0000
Testing done
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
New page:
Dektop:
Mobile:
What areas of the site does it impact? CT homepage
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?