MBMS-73710: Self-Service: Pre-Need: Integration: Service Periods: New Component Design

[adam-antonioli]

Jira Link: MBMS-73710

Are you removing, renaming or moving a folder in this PR?

• No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
• Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

• No
• Yes, and I used the proxy-rewrite steps to test the injected header scenario

Summary

As a Veteran and/or family member, I need to be able to input my Service Period(s) so that I can provide the necessary information needed to get a quick determination on possible eligibility.

Testing done

• Local testing

Screenshots

Before:

⚙️TEST DATA ONLY

Screen.Recording.2024-12-24.at.11.32.06.mov

After:

⚙️TEST DATA ONLY

Screen.Recording.2024-12-24.at.11.29.30.mov

What areas of the site does it impact?

Pre-need form 40-10007: Integration

Acceptance criteria

Quality Assurance & Testing

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Linting warnings have been addressed
• Documentation has been updated (link to documentation *if necessary)
• Screenshot of the developed feature is added
• Accessibility testing has been performed

Error Handling

• Browser console contains no warnings or errors.
• Events are being sent to the appropriate logging solution
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

• Did you login to a local build and verify all authenticated routes work as expected with a test user

[va-vfs-bot]

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

[adam-antonioli]

Only change since last approval by Kenny (@ksantiagoBAH) was disabling 1 other failing unit test.

[adam-antonioli]

Refactored page titles to resolve nested ternaries.

[MichelleDieudonne]

Commenting on the PR so that it will show closed in Jira and stop throwing a warning.