-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accredited-representative-portal: swap css variable imports #32520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@it-harrison Asked a preliminary question.
@@ -1,4 +1,5 @@ | |||
@import "~@department-of-veterans-affairs/formation/sass/shared-variables"; | |||
@import "~@department-of-veterans-affairs/css-library/dist/tokens/scss/variables"; | |||
@import "~@department-of-veterans-affairs/css-library/dist/stylesheets/mixins"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@it-harrison Could you briefly explain why the change in this file also includes a mixins
import? That will help me understand the context better, as I am lacking a little on the frontend architecture for vets-website
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @nihil2501 the reason for the mixin import is that this file is using the @media mixin which is in the formation shared-variables
file but which is not in the css-library variables file
; in css-library
it is in the file ~@department-of-veterans-affairs/css-library/dist/stylesheets/mixins
so there is an extra import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @it-harrison . Looks like I'll need to get readded too the team that owns this code. Working on that first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since @nihil2501 got tied up in getting added to that team
@williamphelps13 Thanks Will and hello there! |
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Are you removing, renaming or moving a folder in this PR?
Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the
#sitewide-public-websites
Slack channel for questions.Did you change site-wide styles, platform utilities or other infrastructure?
Summary
This PR swaps css variable imports from Formation to CSS-Library in accordance with the deprecation of Formation from vets-website
Related issue(s)
3328
Testing done
Screenshots
MHV Landing page and Messages
Profile
Combined Debt Portal
Claims Status
Facility Locator
GI
Injected Header
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?