Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accredited-representative-portal: swap css variable imports #32520

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

it-harrison
Copy link
Contributor

@it-harrison it-harrison commented Oct 16, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

This PR swaps css variable imports from Formation to CSS-Library in accordance with the deprecation of Formation from vets-website

Related issue(s)

3328

Testing done

  • local testing on profile, mhv, and combined-debt-portal

Screenshots

MHV Landing page and Messages

image
image
image
image
image
image
image
image
image
image

Profile

image
image
image
image
image
image
image

Combined Debt Portal

image
image
image
image

Claims Status

image
image
image
image

Facility Locator

image
image

GI

image
image
image
image
image

Injected Header

image
image
image
image
image
image
image
image

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/3328_accredited-representative-portal/main October 16, 2024 21:56 Inactive
@it-harrison it-harrison marked this pull request as ready for review October 16, 2024 22:36
@it-harrison it-harrison requested a review from a team as a code owner October 16, 2024 22:36
Copy link
Contributor

@nihil2501 nihil2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@it-harrison Asked a preliminary question.

@@ -1,4 +1,5 @@
@import "~@department-of-veterans-affairs/formation/sass/shared-variables";
@import "~@department-of-veterans-affairs/css-library/dist/tokens/scss/variables";
@import "~@department-of-veterans-affairs/css-library/dist/stylesheets/mixins";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@it-harrison Could you briefly explain why the change in this file also includes a mixins import? That will help me understand the context better, as I am lacking a little on the frontend architecture for vets-website.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @nihil2501 the reason for the mixin import is that this file is using the @media mixin which is in the formation shared-variables file but which is not in the css-library variables file; in css-library it is in the file ~@department-of-veterans-affairs/css-library/dist/stylesheets/mixins so there is an extra import

@nihil2501 nihil2501 self-requested a review October 22, 2024 16:06
Copy link
Contributor

@nihil2501 nihil2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihil2501
Copy link
Contributor

Thanks @it-harrison . Looks like I'll need to get readded too the team that owns this code. Working on that first.

Copy link
Contributor

@williamphelps13 williamphelps13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since @nihil2501 got tied up in getting added to that team

@it-harrison it-harrison merged commit a5c1db1 into main Oct 23, 2024
76 checks passed
@it-harrison it-harrison deleted the 3328_accredited-representative-portal branch October 23, 2024 21:50
@nihil2501
Copy link
Contributor

@williamphelps13 Thanks Will and hello there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants