site-wide: swap css variable imports #32478
Conversation
There was a problem hiding this comment.
Sentry call found
Sentry captures a lot of data, and we want to make sure that we only keep information that will be useful for troubleshooting issues. This means that PII should not be recorded.
What you can do
Review your call to Sentry and see if you can reasonably reduce any information that is included, or wait for a VSP review.
| // if we fail to fetch suggestions | ||
| } catch (error) { | ||
| if (error?.error?.code === 'OVER_RATE_LIMIT') { | ||
| Sentry.captureException( |
| new Error(`"OVER_RATE_LIMIT" - Search Typeahead`), | ||
| ); | ||
| } | ||
| Sentry.captureException(error); |
| // if we fail to fetch suggestions | ||
| } catch (error) { | ||
| if (error?.error?.code === 'OVER_RATE_LIMIT') { | ||
| Sentry.captureException( |
| new Error(`"OVER_RATE_LIMIT" - Search Typeahead`), | ||
| ); | ||
| } | ||
| Sentry.captureException(error); |
There was a problem hiding this comment.
Your branch needs to be updated with the latest from main. Sitewide recently merged a chunk of changes for the search bar in various places and it's breaking your build, causing some elements to go missing (header/footer, Create Account block, search bar on homepage, search bar on /resources).
Also, please make sure the screenshots / apps tested in the description match the changes here; I think they were copy/paste from another PR.
| @@ -1,4 +1,4 @@ | |||
| @import "~@department-of-veterans-affairs/formation/sass/shared-variables"; | |||
| @import "~@department-of-veterans-affairs/css-library/dist/tokens/scss/variables"; | |||
There was a problem hiding this comment.
Is this minimal.scss used anywhere? I did a Github search and it seems the only usage in vets-website is commented out.
| @@ -1,4 +1,4 @@ | |||
| @import "~@department-of-veterans-affairs/formation/sass/shared-variables"; | |||
| @import "~@department-of-veterans-affairs/css-library/dist/tokens/scss/variables"; | |||
There was a problem hiding this comment.
Not sure this file is needed either. Github search for .usa-button-darker doesn't tie it to any elements.
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Are you removing, renaming or moving a folder in this PR?
Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the
#sitewide-public-websitesSlack channel for questions.Did you change site-wide styles, platform utilities or other infrastructure?
Summary
This PR swaps css variable imports from Formation to CSS-Library in accordance with the deprecation of Formation from vets-website
Related issue(s)
3328
Testing done
Screenshots
MHV Landing page and Messages
Profile
Combined Debt Portal
Claims Status
Facility Locator
GI
Injected Header
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?