Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benefit-eligibility-questionnaire: swap css variable imports #32419

Closed
wants to merge 1 commit into from
Closed

benefit-eligibility-questionnaire: swap css variable imports #32419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/applications/benefit-eligibility-questionnaire/components/SaveResultsModal.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const SaveResultsModal = () => {
};

return (
<div className="vads-u-margin-bottom--2">
<div>
<va-button
id="save-your-results"
message-aria-describedby="Save your results"
Expand All @@ -39,8 +39,8 @@ const SaveResultsModal = () => {
<va-text-input
id="url-input"
hint={null}
aria-label="Copy and save this link to your results"
label="Copy and save this link to your results"
aria-label="Copy link"
label="Copy link"
name="url-input"
type="url"
onChange={() => {}}
Expand Down
5 changes: 2 additions & 3 deletions src/applications/benefit-eligibility-questionnaire/containers/ConfirmationPage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@
this.props.router.goBack();
};

sortBenefitObj(benefitObj, sortKey) {

Check warning on line 148 in src/applications/benefit-eligibility-questionnaire/containers/ConfirmationPage.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/benefit-eligibility-questionnaire/containers/ConfirmationPage.jsx:148:17:Expected 'this' to be used by class method 'sortBenefitObj'.

Check warning on line 148 in src/applications/benefit-eligibility-questionnaire/containers/ConfirmationPage.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/benefit-eligibility-questionnaire/containers/ConfirmationPage.jsx:148:17:Expected 'this' to be used by class method 'sortBenefitObj'.
return [...benefitObj].sort((a, b) => {
let aValue = a[sortKey] || '';
let bValue = b[sortKey] || '';
Expand Down Expand Up @@ -217,13 +217,12 @@
and career benefits. We'll add more types of benefits soon.
</p>

<SaveResultsModal />

<h2 className="vads-u-font-size--h3">Benefits to explore</h2>

<div id="results-container" className="vads-l-grid-container">
<div className="vads-l-row vads-u-margin-y--2 vads-u-margin-x--neg2p5">
<div className="vads-l-col--12">
<SaveResultsModal />
</div>
<div
className="vads-l-col--12 medium-screen:vads-l-col--4 large-screen:vads-l-col--3"
id="filters-section-mobile-toggle"
Expand Down
14 changes: 9 additions & 5 deletions ...pplications/benefit-eligibility-questionnaire/sass/benefit-eligibility-questionnaire.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
@import "~@department-of-veterans-affairs/formation/sass/shared-variables";
@import "~@department-of-veterans-affairs/formation/sass/modules/m-process-list";
@import "~@department-of-veterans-affairs/formation/sass/modules/m-form-process";
@import "~@department-of-veterans-affairs/css-library/dist/tokens/scss/variables";
@import "~@department-of-veterans-affairs/css-library/dist/stylesheets/modules/m-process-list";
@import "~@department-of-veterans-affairs/css-library/dist/stylesheets/modules/m-form-process";
@import "../../../platform/forms/sass/m-schemaform";
@import "~@department-of-veterans-affairs/formation/sass/modules/m-modal";
@import "~@department-of-veterans-affairs/formation/sass/modules/m-omb-info";
@import "~@department-of-veterans-affairs/css-library/dist/stylesheets/modules/m-modal";
@import "~@department-of-veterans-affairs/css-library/dist/stylesheets/modules/m-omb-info";
@import "../../../platform/forms/sass/m-form-confirmation";

#filters-section-desktop {
Expand All @@ -13,6 +13,10 @@
}
}

#filters-section-desktop p {
margin: 10px 0 5px 0;
}

#filters-section-desktop select {
margin-bottom: 35px;
}
Expand Down
Loading