VACMS-16917: DUW Result Page #30684
VACMS-16917: DUW Result Page #30684
Conversation
|
@chriskim2311 I think I did an Airforce flow that wasn't in your examples and got a summary with a typo:
|
|
@laflannery Nice catch this is a prod bug as well I will go ahead and update for both wizards. |
src/applications/discharge-wizard/components/v2/resultsComponents/ResultsSummary.jsx
Outdated
Show resolved
Hide resolved
| @@ -62,7 +62,7 @@ export const board = (formValues, noDRB) => { | |||
|
|
|||
| if (formValues['1_branchOfService'] === 'airForce') { | |||
| return { | |||
| name: 'Air Force Review Boards Agency (AFDRB) for the Air Force', | |||
| name: 'Air Force Review Boards Agency (AFDRB)', | |||
There was a problem hiding this comment.
I asked Fran about removing this redundancy when I made a content change in May. I don't think we got confirmation that it should be removed.
There was a problem hiding this comment.
@FranECross Wondering if this redundancy can be removed? On prod it reads Air Force Review Boards Agency (AFDRB) for the Air Force for the Air Force
There was a problem hiding this comment.
Oh I didn't realize the last four words were actually repeated. I just thought it said Air Force Review Boards Agency (AFDRB) for the Air Force (which is redundant too)
src/applications/discharge-wizard/tests/v2/helpers/index.unit.spec.js
Outdated
Show resolved
Hide resolved
Summary
This PR starts the review page component and completes the routing logic and adds helper functions. Also includes results summary that conditionally renders upgrade instructions based on branch and some form responses.
Related issue(s)
department-of-veterans-affairs/va.gov-cms#16917
Testing done
Tested routes to the results page. Currently only the summary is being rendered for this PR. More content will be added with subsequent PRs.
Ending URL:
/discharge-upgrade-instructions/results/must go through any DUW flow to get to this page.Testing flows:
BCNR and form 149:
BCMR and form 149:
DRB and form 293:
Screenshots
Some example screenshots
BCNR
BCMR
DRB
Air Force Portal
What areas of the site does it impact?
DUW
Acceptance criteria
Quality Assurance & Testing
Error Handling