VACMS-16914: DUW Add prev-application-type question #29288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 22, 2024 13:29
chriskim2311
commented
Apr 22, 2024
| @@ -32,10 +32,12 @@ export const displayConditionsMet = (SHORT_NAME, formResponses) => { | |||
|
|
|||
| if (questionRequirements.includes('FORK')) { | |||
| const forkedReqs = displayConditionsForShortName?.FORK; | |||
| let anyForkConditionsMet = false; | |||
There was a problem hiding this comment.
I realized we do need these vars for the skip ahead questions and checking for a valid DC. Previous logic did not work for all Fork DCs
powellkerry
approved these changes
Apr 23, 2024
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Summary
This PR adds the previous application type question.
Also added more robust test cases for the display logic conditions met function that tests the skip ahead functionality of the FORK logic.
Related issue(s)
department-of-veterans-affairs/va.gov-cms#16914
Testing done
Paths to get to Prev Application Type Question
Path 1
Branch: Any
Discharge Year: Any
Reason: 'I received a DD215 that shows my discharge upgrade or correction. But I want an updated DD214.'
Path 2: Long path hit all questions
Branch: Any
Discharge Year: 2009
Discharge Month: Any
Reason: 'I was discharged due to my sexual orientation (including under the Don’t Ask, Don’t Tell policy).'
Discharge Type: My discharge isn't honorable or under honorable conditions.
Intention: Any
Court Martial: Any
Prev Application: “Yes”
Prev Application Year: 'After 2014', 'After 2011',
'After 2017',
Screenshots
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing