Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHV-54372 Secure Messaging cleanup 556 transition flipper #28623

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

oleksii-morgun
Copy link
Contributor

@oleksii-morgun oleksii-morgun commented Mar 18, 2024

Summary

  • remove cerner_transition_556_t30
  • remove cerner_transition_556_t5

Related issue(s)

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/mhv-54372-cleanup-556-transition-flipper-/main March 18, 2024 21:05 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/mhv-54372-cleanup-556-transition-flipper-/main March 20, 2024 15:29 Inactive
@oleksii-morgun oleksii-morgun marked this pull request as ready for review March 20, 2024 16:40
@oleksii-morgun oleksii-morgun requested review from a team as code owners March 20, 2024 16:40
Copy link
Contributor

@vsaleem vsaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup work! 🧼😀

@va-vfs-bot va-vfs-bot temporarily deployed to master/mhv-54372-cleanup-556-transition-flipper-/main March 22, 2024 15:49 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/mhv-54372-cleanup-556-transition-flipper-/main March 22, 2024 16:01 Inactive
@oleksii-morgun oleksii-morgun merged commit 5fe1b13 into main Mar 25, 2024
82 checks passed
@oleksii-morgun oleksii-morgun deleted the mhv-54372-cleanup-556-transition-flipper- branch March 25, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants