-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-17307: Update alert and link for cta widget #28360
Conversation
src/applications/static-pages/cta-widget/components/CallToActionAlert.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@chriskim2311 I found 2 that are still using the v1 component, are these ours that should be updated? |
@laflannery Nice catch, these are different from the CTA widget. @jilladams Do you know if we own the 2 CTAs in Laura's comment above? |
@chriskim2311 @laflannery @jilladams I checked these - they are owned by the Education Benefits team. |
THanks @randimays - can we/should we update this file here in that case? Because I was working off this list for a couple things (this being one of them) and that's how I found these. |
@laflannery This actually begs the question: should those two instances be using the shared CTA widget? 🤔 In terms of updating this file: https://github.com/department-of-veterans-affairs/vets-website/blob/main/src/applications/static-pages/cta-widget/ctaWidgets.js#L16 I'm not completely sure what it's used for. I'll have to do some investigation. |
Summary
Update Alert and link for CTA widget
Related issue(s)
department-of-veterans-affairs/va.gov-cms#17307
Testing done
Tested locally and in review instance
Screenshots
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria