Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-17307: Update alert and link for cta widget #28360

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

chriskim2311
Copy link
Contributor

@chriskim2311 chriskim2311 commented Mar 5, 2024

Summary

Update Alert and link for CTA widget

Related issue(s)

department-of-veterans-affairs/va.gov-cms#17307

Testing done

Tested locally and in review instance

Screenshots

VA_Prescription_Refill_And_Tracking___Veterans_Affairs

VA_Prescription_Refill_And_Tracking___Veterans_Affairs

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

@va-vfs-bot va-vfs-bot temporarily deployed to master/17307-cta-widget-component-upgrade/main March 5, 2024 20:28 Inactive
@chriskim2311 chriskim2311 marked this pull request as ready for review March 5, 2024 21:03
@chriskim2311 chriskim2311 requested review from a team as code owners March 5, 2024 21:03
@va-vfs-bot va-vfs-bot temporarily deployed to master/17307-cta-widget-component-upgrade/main March 5, 2024 21:21 Inactive
Copy link
Contributor

@randimays randimays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chriskim2311 chriskim2311 merged commit 2f8bd86 into main Mar 7, 2024
78 checks passed
@chriskim2311 chriskim2311 deleted the 17307-cta-widget-component-upgrade branch March 7, 2024 17:02
@laflannery
Copy link

laflannery commented Mar 7, 2024

@chriskim2311 I found 2 that are still using the v1 component, are these ours that should be updated?

  1. Education letters
  2. Verify school enrollment

@chriskim2311
Copy link
Contributor Author

@laflannery Nice catch, these are different from the CTA widget. @jilladams Do you know if we own the 2 CTAs in Laura's comment above?

@randimays
Copy link
Contributor

@chriskim2311 @laflannery @jilladams I checked these - they are owned by the Education Benefits team.

@laflannery
Copy link

THanks @randimays - can we/should we update this file here in that case? Because I was working off this list for a couple things (this being one of them) and that's how I found these.

@randimays
Copy link
Contributor

@laflannery This actually begs the question: should those two instances be using the shared CTA widget? 🤔 In terms of updating this file: https://github.com/department-of-veterans-affairs/vets-website/blob/main/src/applications/static-pages/cta-widget/ctaWidgets.js#L16 I'm not completely sure what it's used for. I'll have to do some investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants