-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAMC system/facilities selectors, connectors, and tests #27557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint is disabled
vets-website
uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.
What you can do
See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.
src/platform/site-wide/drupal-static-data/source-files/vamc-system/selectors/index.js
Show resolved
Hide resolved
...platform/site-wide/drupal-static-data/source-files/vamc-system/tests/preProcess.unit.spec.js
Show resolved
Hide resolved
src/platform/site-wide/drupal-static-data/source-files/vamc-system/tests/utils.unit.spec.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This checks out for me, and I also learned the term "tuples." 😃
* selectors, connectors, and tests * rename test
Summary
Related issue(s)
Testing done
Screenshots
N/A
What areas of the site does it impact?
Added new selectors/connectors/preprocessors for KISS data, no existing site functionality changed.
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
Check that tests (unit) are passing.
Can verify other content-build PR functions here