Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAMC system/facilities selectors, connectors, and tests #27557

Merged
merged 5 commits into from
Jan 25, 2024

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Jan 18, 2024

Summary

  • Selectors, Connectors, and tests for KISS data from Drupal View in content-build
  • Sitewide Facilities

Related issue(s)

Testing done

  • Adds testing for preprocess and selectors
  • Checked unit tests
  • No possibility for e2e test yet until something implements the selectors/connectors

Screenshots

N/A

What areas of the site does it impact?

Added new selectors/connectors/preprocessors for KISS data, no existing site functionality changed.

Acceptance criteria

  • Selector is created in vets-website
  • Connector is creates in vets-website

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (No updated docs)
  • Screenshot of the developed feature is added (n/a)
  • Accessibility testing has been performed (n/a)

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (n/a)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user (No routes or components changed)

Requested Feedback

Check that tests (unit) are passing.
Can verify other content-build PR functions here

@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-16019-KISS-VAMC-system-facilities-list/VACMS-16019-KISS-VAMC-system-facilities-list January 18, 2024 19:32 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-16019-KISS-VAMC-system-facilities-list/VACMS-16019-KISS-VAMC-system-facilities-list January 18, 2024 20:38 Inactive
@eselkin eselkin marked this pull request as ready for review January 18, 2024 22:02
@eselkin eselkin requested review from a team as code owners January 18, 2024 22:02
Copy link

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-16019-KISS-VAMC-system-facilities-list/VACMS-16019-KISS-VAMC-system-facilities-list January 18, 2024 22:24 Inactive
Copy link
Contributor

@maxx1128 maxx1128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This checks out for me, and I also learned the term "tuples." 😃

@eselkin eselkin merged commit c5392ac into main Jan 25, 2024
73 checks passed
@eselkin eselkin deleted the VACMS-16019-KISS-VAMC-system-facilities-list branch January 25, 2024 22:17
pjhill pushed a commit that referenced this pull request Mar 14, 2024
* selectors, connectors, and tests

* rename test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants