-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-15414 Update homepage Cypress tests #26068
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randimays
force-pushed
the
15414-adjust-homepage-cypress
branch
from
October 6, 2023 02:23
56314f5
to
9bd68f9
Compare
va-vfs-bot
temporarily deployed
to
master/15414-adjust-homepage-cypress/main
October 6, 2023 02:24
Inactive
va-vsp-bot
requested a deployment
to
master/15414-adjust-homepage-cypress/main
October 6, 2023 02:24
In progress
randimays
force-pushed
the
15414-adjust-homepage-cypress
branch
from
October 6, 2023 14:26
9bd68f9
to
fc26359
Compare
va-vsp-bot
requested a deployment
to
master/15414-adjust-homepage-cypress/main
October 6, 2023 14:27
In progress
6 tasks
va-vfs-bot
temporarily deployed
to
master/15414-adjust-homepage-cypress/main
October 6, 2023 14:29
Inactive
randimays
force-pushed
the
15414-adjust-homepage-cypress
branch
from
October 6, 2023 19:14
fc26359
to
c627760
Compare
va-vsp-bot
requested a deployment
to
master/15414-adjust-homepage-cypress/main
October 6, 2023 19:16
In progress
va-vfs-bot
temporarily deployed
to
master/15414-adjust-homepage-cypress/main
October 6, 2023 19:17
Inactive
randimays
force-pushed
the
15414-adjust-homepage-cypress
branch
from
October 10, 2023 15:40
c627760
to
a5a084e
Compare
va-vsp-bot
requested a deployment
to
master/15414-adjust-homepage-cypress/main
October 10, 2023 15:42
In progress
va-vfs-bot
temporarily deployed
to
master/15414-adjust-homepage-cypress/main
October 10, 2023 16:01
Inactive
randimays
force-pushed
the
15414-adjust-homepage-cypress
branch
from
October 10, 2023 20:18
a5a084e
to
12ad8d3
Compare
va-vsp-bot
requested a deployment
to
master/15414-adjust-homepage-cypress/main
October 10, 2023 20:19
In progress
randimays
force-pushed
the
15414-adjust-homepage-cypress
branch
from
October 10, 2023 20:29
12ad8d3
to
0fa9c9c
Compare
va-vsp-bot
requested a deployment
to
master/15414-adjust-homepage-cypress/main
October 10, 2023 20:30
In progress
va-vfs-bot
temporarily deployed
to
master/15414-adjust-homepage-cypress/main
October 10, 2023 21:01
Inactive
randimays
force-pushed
the
15414-adjust-homepage-cypress
branch
from
October 11, 2023 15:35
0fa9c9c
to
1adcf78
Compare
va-vsp-bot
requested a deployment
to
master/15414-adjust-homepage-cypress/main
October 11, 2023 15:36
In progress
va-vfs-bot
temporarily deployed
to
master/15414-adjust-homepage-cypress/main
October 11, 2023 15:41
Inactive
randimays
force-pushed
the
15414-adjust-homepage-cypress
branch
from
October 11, 2023 18:20
1adcf78
to
f9b206c
Compare
va-vsp-bot
requested a deployment
to
master/15414-adjust-homepage-cypress/main
October 11, 2023 18:22
In progress
va-vfs-bot
temporarily deployed
to
master/15414-adjust-homepage-cypress/main
October 11, 2023 18:48
Inactive
randimays
force-pushed
the
15414-adjust-homepage-cypress
branch
from
October 12, 2023 15:48
f9b206c
to
9182b89
Compare
va-vsp-bot
requested a deployment
to
master/15414-adjust-homepage-cypress/main
October 12, 2023 15:49
In progress
va-vfs-bot
temporarily deployed
to
master/15414-adjust-homepage-cypress/main
October 12, 2023 16:12
Inactive
randimays
force-pushed
the
15414-adjust-homepage-cypress
branch
from
October 13, 2023 14:18
9182b89
to
e006171
Compare
va-vsp-bot
requested a deployment
to
master/15414-adjust-homepage-cypress/main
October 13, 2023 14:19
In progress
ataker
approved these changes
Oct 13, 2023
randimays
force-pushed
the
15414-adjust-homepage-cypress
branch
from
October 13, 2023 22:47
e006171
to
c881b63
Compare
va-vsp-bot
requested a deployment
to
master/15414-adjust-homepage-cypress/main
October 13, 2023 22:48
In progress
randimays
force-pushed
the
15414-adjust-homepage-cypress
branch
from
October 16, 2023 14:42
c881b63
to
e919950
Compare
va-vsp-bot
requested a deployment
to
master/15414-adjust-homepage-cypress/main
October 16, 2023 14:43
In progress
randimays
force-pushed
the
15414-adjust-homepage-cypress
branch
from
October 16, 2023 14:46
e919950
to
003fbdf
Compare
va-vsp-bot
requested a deployment
to
master/15414-adjust-homepage-cypress/main
October 16, 2023 14:47
In progress
va-vfs-bot
temporarily deployed
to
master/15414-adjust-homepage-cypress/main
October 16, 2023 15:28
Inactive
chriskim2311
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work on this. Tested locally and all are passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The failing (flaky, Platform-flagged) home page test was previously testing
/new-home-page
, which hasn't been accessible for a month or so.I modified the tests to check the functionality of the header and footer on
va.gov
, ascontent-build
is not accessible tovets-website
in the CI, and the header and footer are the only things that resolve. Full surface-level homepage Cypress coverage is incontent-build
already.The Stress Test step of the pipeline will not pass due to a
mochawesome
issue that has been a problem for over a year, and just started resurfacing. Platform is aware of this, but they pointed out that the Stress Test step is not required to pass for merging. Here are all of the Cypress tests passing in that test, though:Related issue(s)
Testing done
Cypress tests pass.