Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15414 Update homepage Cypress tests #26068

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

randimays
Copy link
Contributor

@randimays randimays commented Oct 6, 2023

Summary

The failing (flaky, Platform-flagged) home page test was previously testing /new-home-page, which hasn't been accessible for a month or so.

I modified the tests to check the functionality of the header and footer on va.gov, as content-build is not accessible to vets-website in the CI, and the header and footer are the only things that resolve. Full surface-level homepage Cypress coverage is in content-build already.

The Stress Test step of the pipeline will not pass due to a mochawesome issue that has been a problem for over a year, and just started resurfacing. Platform is aware of this, but they pointed out that the Stress Test step is not required to pass for merging. Here are all of the Cypress tests passing in that test, though:

Related issue(s)

Testing done

Cypress tests pass.

@randimays randimays requested a review from a team as a code owner October 6, 2023 02:22
@randimays randimays force-pushed the 15414-adjust-homepage-cypress branch from 56314f5 to 9bd68f9 Compare October 6, 2023 02:23
@va-vfs-bot va-vfs-bot temporarily deployed to master/15414-adjust-homepage-cypress/main October 6, 2023 02:24 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/15414-adjust-homepage-cypress/main October 6, 2023 02:24 In progress
@randimays randimays force-pushed the 15414-adjust-homepage-cypress branch from 9bd68f9 to fc26359 Compare October 6, 2023 14:26
@va-vsp-bot va-vsp-bot requested a deployment to master/15414-adjust-homepage-cypress/main October 6, 2023 14:27 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/15414-adjust-homepage-cypress/main October 6, 2023 14:29 Inactive
@randimays randimays force-pushed the 15414-adjust-homepage-cypress branch from fc26359 to c627760 Compare October 6, 2023 19:14
@randimays randimays requested a review from a team as a code owner October 6, 2023 19:14
@va-vsp-bot va-vsp-bot requested a deployment to master/15414-adjust-homepage-cypress/main October 6, 2023 19:16 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/15414-adjust-homepage-cypress/main October 6, 2023 19:17 Inactive
@randimays randimays force-pushed the 15414-adjust-homepage-cypress branch from c627760 to a5a084e Compare October 10, 2023 15:40
@va-vsp-bot va-vsp-bot requested a deployment to master/15414-adjust-homepage-cypress/main October 10, 2023 15:42 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/15414-adjust-homepage-cypress/main October 10, 2023 16:01 Inactive
@randimays randimays force-pushed the 15414-adjust-homepage-cypress branch from a5a084e to 12ad8d3 Compare October 10, 2023 20:18
@va-vsp-bot va-vsp-bot requested a deployment to master/15414-adjust-homepage-cypress/main October 10, 2023 20:19 In progress
@randimays randimays force-pushed the 15414-adjust-homepage-cypress branch from 12ad8d3 to 0fa9c9c Compare October 10, 2023 20:29
@va-vsp-bot va-vsp-bot requested a deployment to master/15414-adjust-homepage-cypress/main October 10, 2023 20:30 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/15414-adjust-homepage-cypress/main October 10, 2023 21:01 Inactive
@randimays randimays force-pushed the 15414-adjust-homepage-cypress branch from 0fa9c9c to 1adcf78 Compare October 11, 2023 15:35
@va-vsp-bot va-vsp-bot requested a deployment to master/15414-adjust-homepage-cypress/main October 11, 2023 15:36 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/15414-adjust-homepage-cypress/main October 11, 2023 15:41 Inactive
@randimays randimays force-pushed the 15414-adjust-homepage-cypress branch from 1adcf78 to f9b206c Compare October 11, 2023 18:20
@randimays randimays requested a review from a team as a code owner October 11, 2023 18:20
@va-vsp-bot va-vsp-bot requested a deployment to master/15414-adjust-homepage-cypress/main October 11, 2023 18:22 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/15414-adjust-homepage-cypress/main October 11, 2023 18:48 Inactive
@randimays randimays force-pushed the 15414-adjust-homepage-cypress branch from f9b206c to 9182b89 Compare October 12, 2023 15:48
@va-vsp-bot va-vsp-bot requested a deployment to master/15414-adjust-homepage-cypress/main October 12, 2023 15:49 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/15414-adjust-homepage-cypress/main October 12, 2023 16:12 Inactive
@randimays randimays force-pushed the 15414-adjust-homepage-cypress branch from 9182b89 to e006171 Compare October 13, 2023 14:18
@va-vsp-bot va-vsp-bot requested a deployment to master/15414-adjust-homepage-cypress/main October 13, 2023 14:19 In progress
@randimays randimays force-pushed the 15414-adjust-homepage-cypress branch from e006171 to c881b63 Compare October 13, 2023 22:47
@va-vsp-bot va-vsp-bot requested a deployment to master/15414-adjust-homepage-cypress/main October 13, 2023 22:48 In progress
@randimays randimays force-pushed the 15414-adjust-homepage-cypress branch from c881b63 to e919950 Compare October 16, 2023 14:42
@va-vsp-bot va-vsp-bot requested a deployment to master/15414-adjust-homepage-cypress/main October 16, 2023 14:43 In progress
@randimays randimays force-pushed the 15414-adjust-homepage-cypress branch from e919950 to 003fbdf Compare October 16, 2023 14:46
@va-vsp-bot va-vsp-bot requested a deployment to master/15414-adjust-homepage-cypress/main October 16, 2023 14:47 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/15414-adjust-homepage-cypress/main October 16, 2023 15:28 Inactive
Copy link
Contributor

@chriskim2311 chriskim2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work on this. Tested locally and all are passing

@randimays randimays merged commit 1050b39 into main Oct 16, 2023
@randimays randimays deleted the 15414-adjust-homepage-cypress branch October 16, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants