Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bdex/57392 make phone number optional #24647

Closed
wants to merge 8 commits into from

Conversation

mchae-nava
Copy link
Contributor

@mchae-nava mchae-nava commented Jun 22, 2023

Summary

When inputting contact information, make phone number optional to match the paper form. Includes some copy updates regarding phone number

vets-json-schema PR:
department-of-veterans-affairs/vets-json-schema#781

Related issue(s)

https://app.zenhub.com/workspaces/disability-experience-63dbdb0a401c4400119d3a44/issues/gh/department-of-veterans-affairs/va.gov-team/57392

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@mchae-nava mchae-nava requested a review from a team June 22, 2023 20:32
@mchae-nava mchae-nava requested review from a team as code owners June 22, 2023 20:32
@va-vfs-bot va-vfs-bot temporarily deployed to master/bdex/57392-make-phone-number-optional/main June 22, 2023 20:33 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/bdex/57392-make-phone-number-optional/main June 22, 2023 20:33 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/bdex/57392-make-phone-number-optional/main June 23, 2023 18:30 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/bdex/57392-make-phone-number-optional/main June 23, 2023 18:31 In progress
@va-vsp-bot va-vsp-bot requested a deployment to master/bdex/57392-make-phone-number-optional/main June 27, 2023 18:56 In progress
Comment on lines +22 to +26
You can go to your{' '}
<a href="/profile" target="_blank" rel="noreferrer">
VA.gov profile
</a>{' '}
to confirm your phone number.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prefill will include a primaryPhone value. I think it'd be better to show, then to tell them to go look in profile? Also, you can access the Veteran's mobile, home and work phone within redux state.

redux dev tools showing path of: State - user - profile - vapContactInfo and mobilePhone, homePhone and workPhone object values

I have no idea which one the VA will actually use when calling the Veteran.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's good to know, thanks for that! I will bring it up to design

@va-vfs-bot va-vfs-bot temporarily deployed to master/bdex/57392-make-phone-number-optional/main June 27, 2023 21:44 Inactive
@mchae-nava mchae-nava changed the title Draft: Bdex/57392 make phone number optional Bdex/57392 make phone number optional Jul 3, 2023
Copy link
Contributor

@rmessina1010 rmessina1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

This PR is stale because it has been open 120 days with no activity. It will recieve a stale label every day for 14 days before being closed unless it recieves a comment or the stale label is removed.

@github-actions github-actions bot added the Stale label Feb 16, 2024
@github-actions github-actions bot closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants