Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VA-11591] Remove flipper facilities_ppms_suppress_pharmacies #23315

Closed
wants to merge 3 commits into from

Conversation

maxx1128
Copy link
Contributor

@maxx1128 maxx1128 commented Feb 6, 2023

Summary

This pull request removes the facilities_ppms_suppress_pharmacies flipper and related functionality from the front end. Pharmacies are no longer suppressed from the facility search as a result.

I am with the facilities team, which does work and maintenance over the component in question.

There is no known end date for this flipper as of yet.

Related issue(s)

Testing done

Before the change, the flipper (when active) would suppress pharmacy data from the search by deleting it. These changes can be verified by going to the facility search and seeing pharmacy data included in the search. Testing done was visual and by visiting the facility search to ensure it still worked.

Screen Shot 2023-02-06 at 2 16 38 PM

What areas of the site does it impact?

The facility locator.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.

@maxx1128 maxx1128 force-pushed the va-11591-remove-flipper-suppress-pharmacies branch from 43d304e to 843ba81 Compare February 6, 2023 20:15
@va-vfs-bot va-vfs-bot temporarily deployed to master/va-11591-remove-flipper-suppress-pharmacies/main February 6, 2023 20:28 Inactive
@maxx1128 maxx1128 force-pushed the va-11591-remove-flipper-suppress-pharmacies branch from 843ba81 to fe46e95 Compare February 7, 2023 15:03
@va-vfs-bot va-vfs-bot temporarily deployed to master/va-11591-remove-flipper-suppress-pharmacies/main February 7, 2023 15:06 Inactive
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

This PR is stale because it has been open 120 days with no activity. It will recieve a stale label every day for 14 days before being closed unless it recieves a comment or the stale label is removed.

@github-actions github-actions bot added the Stale label Jun 8, 2023
@github-actions github-actions bot closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants