Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VA-10656] Remove facility_locator_lat_long_only flipper #22758

Closed
wants to merge 3 commits into from

Conversation

maxx1128
Copy link
Contributor

Description

The facility_locator_lat_long_only flipper was implemented with unexpected consequences, so the front-end code for it is good to remove.

Original issue(s)

department-of-veterans-affairs/va.gov-cms#10656

Testing done

Code search

Acceptance criteria

  • All references to facility_locator_lat_long_only are removed from the front-end without anything breaking.

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@maxx1128 maxx1128 requested review from a team as code owners November 22, 2022 20:02
@maxx1128
Copy link
Contributor Author

maxx1128 commented Nov 23, 2022

This flipper is set to "off" in production, so I'm adding another commit to remove the front-end functionality as well.

UPDATE: There's no front-end HTML code related to this PR, so it's already good to go once the tests pass

@maxx1128 maxx1128 force-pushed the VA-10656-remove-facility-lat-long-only branch from d5a3bda to 0289319 Compare November 28, 2022 17:13
@va-vfs-bot va-vfs-bot temporarily deployed to master/VA-10656-remove-facility-lat-long-only/main November 28, 2022 17:14 Inactive
@maxx1128 maxx1128 force-pushed the VA-10656-remove-facility-lat-long-only branch from 0289319 to 35e9c6d Compare November 30, 2022 16:04
@va-vfs-bot va-vfs-bot temporarily deployed to master/VA-10656-remove-facility-lat-long-only/main November 30, 2022 16:06 Inactive
@github-actions
Copy link

This PR is stale because it has been open 120 days with no activity. It will recieve a stale label every day for 14 days before being closed unless it recieves a comment or the stale label is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants