Review feedback

src/applications/simple-forms/form-upload/helpers/index.js

@@ -80,12 +80,7 @@ export const getMockData = (mockData, isLocalhost) => {
 };
 
 export const formattedPhoneNumber = phoneNumber => {
-  const phoneNumberWithoutDashes = phoneNumber.replaceAll('-', '');
-  return `(${phoneNumberWithoutDashes.substr(
-    0,
-    3,
-  )}) ${phoneNumberWithoutDashes.substr(
-    3,
-    3,
-  )}-${phoneNumberWithoutDashes.substr(6, 4)}`;
+  const digits = phoneNumber.replaceAll('-', '');
+  // Formats the phone number to look like this: (123) 456-7890
+  return digits.replace(/(\d{3})(\d{3})(\d{4})/, '($1) $2-$3');
 };

src/applications/simple-forms/form-upload/tests/e2e/fixtures/data/transformed/submit-transformer.json

@@ -1,9 +1,13 @@
 {
   "confirmationCode": "123456",
   "formNumber": "21-0779",
-  "options": {
-    "ssn": "234232345",
-    "vaFileNumber": "456454567",
-    "zipCode": "12345"
+  "formData": {
+    "idNumber": {
+      "ssn": "234232345",
+      "vaFileNumber": "456454567"
+    },
+    "postalCode": "12345",
+    "fullName": "John Veteran",
+    "email": "[email protected]"
   }
 }