Skip to content

Commit

Permalink
Refactors
Browse files Browse the repository at this point in the history
  • Loading branch information
rjohnson2011 committed Dec 20, 2024
1 parent b2cc7be commit 9d40f84
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React from 'react';

Check warning on line 1 in src/applications/representative-appoint/pages/claimant/claimantPersonalInformation.js

View workflow job for this annotation

GitHub Actions / App Isolation Annotations

Staged Continuous Deployment App Isolation Conflict

*WARNING* This PR contains changes related to an application that is currently not isolated. As of Feb 3, 2025 deployment may no longer be possible for apps that are not isolated. Please isolate this app from other directories in 'src/applications' to prevent future deployment issues. More information on your app's status can be seen here: https://department-of-veterans-affairs.github.io/veteran-facing-services-tools/frontend-support-dashboard/cross-app-import-report Please reach out to Frontend Platform Support with any questions.
import { cloneDeep } from 'lodash';

import {
dateOfBirthUI,
dateOfBirthSchema,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ export const uiSchema = {
expandUnder: 'claimantRelationship',
expandUnderCondition: 'RELATIONSHIP_NOT_LISTED',
expandedContentFocus: true,
maxLength: 42,
},
'ui:errorMessages': {
required: `Please enter your relationship to the Veteran`,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
import React from 'react';

Check warning on line 1 in src/applications/representative-appoint/tests/pages/claimant/claimantContactMailing.unit.spec.jsx

View workflow job for this annotation

GitHub Actions / App Isolation Annotations

Staged Continuous Deployment App Isolation Conflict

*WARNING* This PR contains changes related to an application that is currently not isolated. As of Feb 3, 2025 deployment may no longer be possible for apps that are not isolated. Please isolate this app from other directories in 'src/applications' to prevent future deployment issues. More information on your app's status can be seen here: https://department-of-veterans-affairs.github.io/veteran-facing-services-tools/frontend-support-dashboard/cross-app-import-report Please reach out to Frontend Platform Support with any questions.
import { expect } from 'chai';
import { render } from '@testing-library/react';

import { DefinitionTester } from 'platform/testing/unit/schemaform-utils';
import { $ } from 'platform/forms-system/src/js/utilities/ui';

import formConfig from '../../../config/form';

describe('Claimant Contact Mailing page', () => {
Expand All @@ -22,6 +24,7 @@ describe('Claimant Contact Mailing page', () => {
formData={{}}
/>,
);

expect($('button[type="submit"]', container)).to.exist;
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ import React from 'react';
import { render } from '@testing-library/react';
import { expect } from 'chai';
import { DefinitionTester } from 'platform/testing/unit/schemaform-utils';

import mockFormData from '../../fixtures/data/form-data.json';

import formConfig from '../../../config/form';

describe('Veteran Contact Mailing page', () => {
Expand All @@ -21,6 +23,7 @@ describe('Veteran Contact Mailing page', () => {
formData={mockFormData}
/>,
);

expect(container.querySelector('button[type="submit"]')).to.exist;
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { expect } from 'chai';
import { render } from '@testing-library/react';
import { Provider } from 'react-redux';
import configureStore from 'redux-mock-store';

import { DefinitionTester } from 'platform/testing/unit/schemaform-utils';
import formConfig from '../../../config/form';

Expand All @@ -11,6 +12,7 @@ describe('Veteran Identification page', () => {
schema,
uiSchema,
} = formConfig.chapters.veteranInfo.pages.veteranIdentification;

const mockStore = configureStore();
const store = mockStore({
user: { login: { currentlyLoggedIn: true } },
Expand All @@ -28,6 +30,7 @@ describe('Veteran Identification page', () => {
/>
</Provider>,
);

expect(container.querySelector('button[type="submit"]')).to.exist;
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { expect } from 'chai';
import { render } from '@testing-library/react';
import { Provider } from 'react-redux';
import configureStore from 'redux-mock-store';

import { DefinitionTester } from 'platform/testing/unit/schemaform-utils';
import formConfig from '../../../config/form';

Expand All @@ -11,6 +12,7 @@ describe('Veteran Personal Information page', () => {
schema,
uiSchema,
} = formConfig.chapters.veteranInfo.pages.veteranPersonalInformation;

const mockStore = configureStore();
const store = mockStore({
user: { login: { currentlyLoggedIn: true } },
Expand All @@ -28,6 +30,7 @@ describe('Veteran Personal Information page', () => {
/>
</Provider>,
);

expect(container.querySelector('button[type="submit"]')).to.exist;
});

Expand Down

0 comments on commit 9d40f84

Please sign in to comment.