Skip to content

Commit

Permalink
PTEMSVT-342-349-244-365 Multiple copy edits (#33728)
Browse files Browse the repository at this point in the history
* PTEMSVT-342-349-244-365 Multiple copy edits

* PTEMSVT-342-349-244-365 Multiple copy edits

* PTEMSVT-342-349-244-365 Multiple copy edits

---------

Co-authored-by: Ian <[email protected]>
  • Loading branch information
iseabock-va and iseabock authored Dec 27, 2024
1 parent e9afc58 commit 6946869
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 37 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ const BenefitCard = ({ benefit }) => {
</h3>
<p className="vads-u-margin-y--0">{description}</p>
<div>
<div className="vads-u-display--inline-block vads-u-margin-right--2">
<div className="vads-u-margin-right--2">
{renderLink(learnMoreURL, 'Learn more', `Learn more about ${name}`)}
</div>
<div className="vads-u-display--inline-block">
<div>
{renderLink(applyNowURL, 'Apply now', `Apply now for ${name}`)}
</div>
</div>
Expand Down
8 changes: 0 additions & 8 deletions src/applications/discover-your-benefits/config/form.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,6 @@ export const formConfig = {
noAuth: 'Please sign in again to continue your application for benefits.',
},
title: 'Discover your benefits',
subTitle: ({ currentLocation }) => {
if (
isOnReviewPage(currentLocation) ||
isOnConfirmationPage(currentLocation)
)
return '';
return `Please answer the questions to help us recommend\nhelpful resources and benefits.`;
},
defaultDefinitions: {
fullName,
ssn,
Expand Down
4 changes: 2 additions & 2 deletions src/applications/discover-your-benefits/constants/benefits.js
Original file line number Diff line number Diff line change
Expand Up @@ -723,7 +723,7 @@ export const BENEFITS_LIST = [
category: categories.EDUCATION,
id: 'TGI',
description:
'If you’re a spouse or dependent child of a Veteran or service member, you may be eligible to use transferred education benefits for your classes and training. Learn more about these benefits and how to apply.',
'You may be able to transfer your unused Post-9/11 GI Bill benefits to your spouse or dependent children. Learn more about this process and how to request a transfer of benefits.',
isTimeSensitive: false,
mappings: {
[mappingTypes.GOALS]: [goalTypes.SCHOOL, goalTypes.UNDERSTAND],
Expand All @@ -739,7 +739,7 @@ export const BENEFITS_LIST = [
[mappingTypes.GI_BILL]: [anyType.ANY],
},
learnMoreURL:
'https://www.va.gov/family-and-caregiver-benefits/education-and-careers/transferred-gi-bill-benefits/',
'https://www.va.gov/education/transfer-post-9-11-gi-bill-benefits/',
applyNowURL: '',
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,31 +46,6 @@ describe('Questionnaire Form - Title Function', () => {
});
});

describe('Questionnaire Form - SubTitle Function', () => {
describe('title function', () => {
it('should return blank when on the confirmation page', () => {
const currentLocation = { pathname: '/confirmation' };
const title = formConfig.subTitle({ currentLocation });
expect(title).to.equal('');
});

it('should return blank when on the review page', () => {
const currentLocation = { pathname: '/review-and-submit' };
const title = formConfig.subTitle({ currentLocation });
expect(title).to.equal('');
});

it('should return "Please answer the questions to help us recommend helpful resources and benefits." by default', () => {
const currentLocation = { pathname: '/some-other-page' };
const title = formConfig.subTitle({ currentLocation });
expect(title).to.equal(
`Please answer the questions to help us recommend
helpful resources and benefits.`,
);
});
});
});

describe('Questionnaire Form - Chapter 1: Goals', () => {
const { chapters } = formConfig;
const { chapter1 } = chapters;
Expand Down

0 comments on commit 6946869

Please sign in to comment.