[DR-70429] remove timezone enums from appeals schemas #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mottie
approved these changes
Dec 5, 2023
| { "$ref": "#/definitions/timezone" } | ||
| ] | ||
| } | ||
| "timezone": { "type": "string" } | ||
| }, | ||
| "required": ["homeless", "phone", "email"], |
There was a problem hiding this comment.
Do we need to add "timezone" to this required field?
| "$ref": "#/definitions/timezone" | ||
| } | ||
| ] | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ |
| "$ref": "#/definitions/timezone" | ||
| } | ||
| ] | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ |
| "$ref": "#/definitions/timezone" | ||
| } | ||
| ] | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ |
| @@ -196,753 +196,7 @@ | |||
| }, | |||
| "timezone": { | |||
| "type": "string", | |||
There was a problem hiding this comment.
Add "timezone" to required? Not sure where the required field is...
|
@Mottie I didn't feel confident enough in how the schemas are used to validate to make anything required that wasn't required before 🥴 but if you're sure of where I should be adding required values, I can go ahead and do that. I added a note in a few of the files but to summarize what I found — I tried to see if we could implement test specs for these schemas but they're using a structural version that isn't supported by the testing tool we're using for other specs. |
rjohnson2011
approved these changes
Dec 7, 2023
anniebtran
deleted the
DR-70429-remove-timezone-enums-from-appeals-schemas
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New schema
We're removing the enum for timezones in the Decision Reviews schemas (SC, HLR, NOD) and letting Lighthouse take care of validating the proper set of timezones so that we don't have to manage them here and on the Lighthouse side. It makes it much easier for us to maintain and reduces errors that arise from an enum being out of date (i.e. the enums defined here... see ticket below for more details about the issues we're seeing)
Package.json version bumped
DR | Update timezone list for SC, HLR, and NOD in
vets-json-schemava.gov-team#70429Pull Requests to update the schema in related repositories
After you've merged your changes to vets-json-schema you'll need to make PR's to vets-website and vets-api. Please link them here.