Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

65373 override Mexico states for 1010-ez #804

Closed

Conversation

@jadon1979 jadon1979 requested review from a team as code owners September 27, 2023 21:08
@jadon1979 jadon1979 force-pushed the feature/65373-override-mexico-states-for-1010ez branch from 703b16c to 996f58e Compare September 28, 2023 03:00
@rmtolmach
Copy link
Contributor

Hi @jadon1979! I couple questions:

  1. Are there corresponding vets-api and vets-website PRs to go with this?
  2. Are you aiming to get this in before the PACT Act application deadline on the 30th or can it wait? We've been advised to not merge anything with too much risk this week leading up to the deadline.

@hdjustice
Copy link

Hi @rmtolmach !
I dont have an answer for your first question (@longmd - maybe you might know?)
However for your second: This change is to address application submissions that are failing all retries due to the Mexico province name being spelled out in the schema, instead of having the appropriate abbreviations. Essentially, this is to remove risk of further failures, especially during these last few days of the enrollment period.

@rmtolmach
Copy link
Contributor

Hi @hdjustice! ok, so it sounds like yall are trying to get this in ASAP to prevent errors over the next few days.

@longmd
Copy link
Contributor

longmd commented Sep 28, 2023

@rmtolmach , after doing some more digging on the front end, we are looking to maybe take a different approach that will discard the need for this schema change. We are going to put a pin in this for the moment and revisit early next week.

@jadon1979 jadon1979 closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants