Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 10-10EZR schema #794

Merged
merged 50 commits into from
Oct 18, 2023
Merged

Add 10-10EZR schema #794

merged 50 commits into from
Oct 18, 2023

Conversation

lihanli
Copy link
Contributor

@lihanli lihanli commented Aug 22, 2023

New schema

new schema for the 10-10EZR form
department-of-veterans-affairs/va.gov-team#63591

Pull Requests to update the schema in related repositories

After you've merged your changes to vets-json-schema you'll need to make PR's to vets-website and vets-api. Please link them here.

@JoshingYou1 JoshingYou1 requested a review from longmd October 5, 2023 18:48
@JoshingYou1 JoshingYou1 marked this pull request as ready for review October 5, 2023 18:49
@JoshingYou1 JoshingYou1 requested review from a team as code owners October 5, 2023 18:49
@RachalCassity
Copy link
Member

@lihanli Is this PR still relevant or can this PR be closed?

@lihanli
Copy link
Contributor Author

lihanli commented Oct 17, 2023

@RachalCassity @JoshingYou1 has taken over this PR, but we still want to merge this

src/common/definitions.js Outdated Show resolved Hide resolved
@lihanli
Copy link
Contributor Author

lihanli commented Oct 18, 2023

@JoshingYou1 you need to run yarn run build and commit

dist/10-10EZ-schema.json Outdated Show resolved Hide resolved
Copy link
Contributor Author

@lihanli lihanli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@longmd longmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@JoshingYou1 JoshingYou1 merged commit c2c0bf4 into master Oct 18, 2023
5 checks passed
@JoshingYou1 JoshingYou1 deleted the fd-form branch October 18, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants