Refactored 'associations' to 'veteranContacts' for less ambiguity (#821)

department-of-veterans-affairs · Nov 29, 2023 · c2b24c2 · c2b24c2
1 parent 2092ad2
commit c2b24c2
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/dist/10-10EZR-schema.json b/dist/10-10EZR-schema.json
@@ -970,7 +970,7 @@
         true
       ]
     },
-    "associations": {
+    "veteranContacts": {
       "type": "array",
       "items": {
         "type": "object",

diff --git a/dist/definitions.json b/dist/definitions.json
@@ -1297,7 +1297,7 @@
       "step"
     ]
   },
-  "associations": {
+  "hcaVeteranContacts": {
     "type": "array",
     "items": {
       "type": "object",

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "vets-json-schema",
-  "version": "20.32.4",
+  "version": "20.33.4",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/department-of-veterans-affairs/vets-json-schema.git"

diff --git a/src/common/definitions.js b/src/common/definitions.js
@@ -366,7 +366,7 @@ const hcaDependents = {
   },
 };
 
-const associationRelationships = {
+const hcaVeteranContactRelationships = {
   type: 'string',
   enum: [
     'BROTHER',
@@ -387,27 +387,27 @@ const associationRelationships = {
   ],
 };
 
-const associationTypes = {
+const hcaVeteranContactTypes = {
   type: 'string',
   enum: ['Primary Next of Kin', 'Other Next of Kin', 'Emergency Contact', 'Other emergency contact'],
 };
 
-const association = {
+const hcaVeteranContact = {
   type: 'object',
   properties: {
     fullName: hcaFullName,
     primaryPhone: hcaPhone,
     alternatePhone: hcaPhone,
     address: hcaAddress,
-    relationship: associationRelationships,
-    contactType: associationTypes,
+    relationship: hcaVeteranContactRelationships,
+    contactType: hcaVeteranContactTypes,
   },
   required: ['fullName', 'primaryPhone', 'address', 'relationship', 'contactType'],
 };
 
-const associations = {
+const hcaVeteranContacts = {
   type: 'array',
-  items: association,
+  items: hcaVeteranContact,
 };
 
 // Historically a veteran's service number has been between 5 and 8 digits,
@@ -942,7 +942,7 @@ export default {
   netWorthAccount,
   relationshipAndChildName,
   relationshipAndChildType,
-  associations,
+  hcaVeteranContacts,
   marriages,
   files,
   requiredServiceHistory,

diff --git a/src/schemas/10-10EZR/schema.js b/src/schemas/10-10EZR/schema.js
@@ -75,7 +75,7 @@ const schema = {
       type: 'boolean',
       enum: [true],
     },
-    associations: definitions.associations,
+    veteranContacts: definitions.hcaVeteranContacts,
   },
   required: [
     'privacyAgreementAccepted',