-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add syntax highlighting for markdown code blocks #3507
Merged
adamwhitlock1
merged 8 commits into
main
from
authed-patterns/aw/185/add-syntax-highlighting-for-markdown-code-blocks
Nov 18, 2024
Merged
Add syntax highlighting for markdown code blocks #3507
adamwhitlock1
merged 8 commits into
main
from
authed-patterns/aw/185/add-syntax-highlighting-for-markdown-code-blocks
Nov 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clipboard button, config rouge for highlighting
adamwhitlock1
temporarily deployed
to
development
November 8, 2024 19:43 — with
GitHub Actions
Inactive
adamwhitlock1
temporarily deployed
to
development
November 12, 2024 20:09 — with
GitHub Actions
Inactive
adamwhitlock1
changed the title
Add syntax highlighting for markdown code blocks [WIP]
Add syntax highlighting for markdown code blocks
Nov 12, 2024
adamwhitlock1
temporarily deployed
to
development
November 12, 2024 20:36 — with
GitHub Actions
Inactive
@humancompanion-usds I'd be curious to get your opinion on this syntax highlighting as far as the colors that I chose. I tried to align with the design system as much as possible and use the token colors throughout. |
1 task
Andrew565
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ng-for-markdown-code-blocks
adamwhitlock1
deleted the
authed-patterns/aw/185/add-syntax-highlighting-for-markdown-code-blocks
branch
November 18, 2024 18:11
Looks great @adamwhitlock1 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
copy
button to easily copy code to clipboard. This is not something we have to include, but I thought it was a nice addition. It uses the VA button and only about 35 lines of JS to get the copy functionality working.Screenshots
I went through the site to look for any styling issues that this change could make and tried to address any of those issues where they occurred. There really weren't many layout problems introduced by this, but below are some screenshots of the main types of pages that have changed.
Mobile