Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a11y note on external link #3346

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Add a11y note on external link #3346

merged 3 commits into from
Nov 22, 2024

Conversation

rsmithadhoc
Copy link
Contributor

@rsmithadhoc rsmithadhoc mentioned this pull request Oct 8, 2024
Closed
3 tasks
@LWWright7 LWWright7 closed this Oct 10, 2024
@jamigibbs jamigibbs reopened this Nov 5, 2024
@humancompanion-usds
Copy link
Collaborator

@rsmithadhoc - Is this ready to go? It's been in draft for a bit.

@rsmithadhoc
Copy link
Contributor Author

@rsmithadhoc - Is this ready to go? It's been in draft for a bit.

I think it's just waiting on this to be done first #3303

@humancompanion-usds humancompanion-usds marked this pull request as ready for review November 18, 2024 22:12
@humancompanion-usds humancompanion-usds requested a review from a team as a code owner November 18, 2024 22:12
danbrady
danbrady approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@danbrady danbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andrew565
Copy link
Contributor

@rsmithadhoc #3303 has been completed so you can merge this whenever you're ready.

@rsmithadhoc rsmithadhoc merged commit 591b183 into main Nov 22, 2024
4 checks passed
@rsmithadhoc rsmithadhoc deleted the external-link-docs branch November 22, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbrady danbrady danbrady approved these changes

@Andrew565 Andrew565 Andrew565 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rsmithadhoc @humancompanion-usds @Andrew565 @danbrady @jamigibbs @LWWright7