Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Storybook Assets to Root Directory using Gulp #2238

Merged
merged 5 commits into from
Nov 1, 2023

Conversation

harshil1793
Copy link
Contributor

@harshil1793 harshil1793 commented Oct 31, 2023

This PR introduces a new Gulp task that automates the process of copying assets from the storybook/assets/ directory to the root assets/ directory. This ensures consistent asset paths across different environments, addressing the issue of assets not being found in the production environment.

#1977

@harshil1793 harshil1793 requested a review from a team as a code owner October 31, 2023 22:42
config/gulp/storybook.js Outdated Show resolved Hide resolved
@jamigibbs
Copy link
Contributor

The new gulp task will not run until you import it in gulpfile.js before the build script runs:

Screenshot 2023-11-01 at 9 19 30 AM

@jamigibbs
Copy link
Contributor

@harshil1793 Can you link to the original ticket in the description of this PR so that we have a reference to why we are doing this?

gulpfile.js Show resolved Hide resolved
@harshil1793 harshil1793 requested a review from jamigibbs November 1, 2023 19:02
Copy link
Contributor

@jamigibbs jamigibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try! 🤞

@harshil1793 harshil1793 merged commit 71366a5 into main Nov 1, 2023
5 checks passed
@harshil1793 harshil1793 deleted the 1977-storybook-assets branch November 1, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants