Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchors inside va-introtext don't inherit font-sizing, so anchors are too small #2981

Closed
1 of 6 tasks
dcloud opened this issue Jun 28, 2024 · 3 comments
Closed
1 of 6 tasks
Assignees
Labels
bug Something isn't working platform-design-system-team

Comments

@dcloud
Copy link

dcloud commented Jun 28, 2024

Bug Report

  • I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

The "Go back to the previous version of My HealtheVet" link is inside of a div with the .va-introtext class applied. The USWDS typography changes introduced in department-of-veterans-affairs/vets-website#30089 appear to override the intended font-size of text in the va-introtext component

Screen Shot 2024-06-28 at 13 09 22

What I expected to happen

Text for an anchor element inside of the .va-introtext element to inherit the intro text font size

Reproducing

  • Formation version:
  • Device: (e.g. iPhone 8, Macbook)
  • Browser: (e.g. Firefox, IE 11)

Steps to reproduce:

  1. Load a page with an anchor element inside an element with the .va-introtext applied.

Urgency

How urgent is this request? Please select the appropriate option below and/or provide details

  • This bug is blocking work currently in progress
  • This bug is affecting work currently in progress but we have a workaround
  • This bug is blocking work planned within the next few sprints
  • This bug is not blocking any work
  • Other

Details

@dcloud dcloud added bug Something isn't working platform-design-system-team labels Jun 28, 2024
@micahchiang
Copy link
Contributor

Proposed Fix

anchor tags in .va-introtext elements need a little more specificity to ensure they inherit the right font-size. In order to keep formation and css-library in sync during our transition, this needs to be updated in two places:

  1. Add a to this style block in Formation so it reads p, a {...}
  2. Do the same as above to this style block in css-library

Once these changes are made, new releases for both Formation and css-library should be created and published to vets-website.

@micahchiang
Copy link
Contributor

@micahchiang
Copy link
Contributor

Closing. Resolved here - department-of-veterans-affairs/vets-website#30604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform-design-system-team
Projects
None yet
Development

No branches or pull requests

2 participants