Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump all MHV Home link fonts to 20px #85688

Closed
wesrowe opened this issue Jun 11, 2024 · 6 comments
Closed

Bump all MHV Home link fonts to 20px #85688

wesrowe opened this issue Jun 11, 2024 · 6 comments
Assignees
Labels
Cartographers MHV on VAgov team my-health former "health-apartment" tag - Migrating MHV to va.gov

Comments

@wesrowe
Copy link
Contributor

wesrowe commented Jun 11, 2024

Description

User story

As a Cartography team member, I want to increase the MHV Home link font size to 20px after the VADS body increases to just under 17px, so that these links remain distinctly larger than body fonts.

Notes

Possible tasks:

Acceptance criteria

  • Increased mhv-c-link links (Resources/Spotlight) that were 19px (1.1875rem) to 20px
  • Increased link in MR box (Go back to old version) to 20px
  • Increased BTSSS link under Payments to 20px
  • Increased 'mhv-c-nav-link' (eg Go to inbox) to 20px
  • Design review in Staging
  • QA review
@wesrowe wesrowe added Cartographers MHV on VAgov team my-health former "health-apartment" tag - Migrating MHV to va.gov needs-refinement Identifies tickets that need to be refined labels Jun 11, 2024
@wesrowe wesrowe changed the title Bump MHV Home link font to 20px Bump all MHV Home link fonts to 20px Jun 12, 2024
@wesrowe wesrowe removed the needs-refinement Identifies tickets that need to be refined label Jun 12, 2024
@radavis radavis self-assigned this Jun 24, 2024
@radavis
Copy link
Contributor

radavis commented Jun 24, 2024

Spotlight links are using <va-link />web component which doesn't allow for custom styling/font-sizes.

@radavis
Copy link
Contributor

radavis commented Jun 25, 2024

Slack convo

@radavis
Copy link
Contributor

radavis commented Jun 26, 2024

After a discussion, a more accurate AC for this ask would be simply:

  • Links that were 19px are now 20px in size.

@allanto-ah
Copy link
Contributor

@radavis

The "Go back to the previous..." link in the intro text on the landing page seems a bit small compared to the intro text. The intro text is at 20px and the link is 16.96px. Is this expected?

Screenshot 2024-06-27 at 9.18.04 AM.png

@radavis
Copy link
Contributor

radavis commented Jun 28, 2024

@allanto-ah, Looking at the Figma link provided by @fmccaf1, the link and text in that section should be at ~17px. The 16.96px value is due to the way the design system is changing text sizes across apps.

Screenshot from 2024-06-28 12-11-55

@allanto-ah
Copy link
Contributor

Environment: Staging

Verified that the above changes have been made.

The above issue about the "Go back..." link in the intro text is a bug in the design system. There is a bug ticket filed to address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cartographers MHV on VAgov team my-health former "health-apartment" tag - Migrating MHV to va.gov
Projects
None yet
Development

No branches or pull requests

4 participants