Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evidence_submissions table and run db migrate #20318

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

pmclaren19
Copy link
Contributor

@pmclaren19 pmclaren19 commented Jan 16, 2025

Summary

This pr is the first pr to merge some of the work from #20105.

This pr adds the db table evidence_submissions with all of the necessary fields through a migration file and includes the schema changes.

Related issue(s)

  • Link to ticket created in va.gov-team repo here
  • Link to draft pr that this is a part of here

What areas of the site does it impact?

Claim Status Tool

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@pmclaren19 pmclaren19 self-assigned this Jan 16, 2025
@pmclaren19 pmclaren19 marked this pull request as ready for review January 16, 2025 16:03
@pmclaren19 pmclaren19 requested review from a team as code owners January 16, 2025 16:03
@va-vfs-bot va-vfs-bot temporarily deployed to 100037-Add-Evidence-Submission-Table/main/main January 16, 2025 16:08 Inactive
samcoforma
samcoforma previously approved these changes Jan 16, 2025
samcoforma
samcoforma previously approved these changes Jan 16, 2025
@stevenjcumming
Copy link
Contributor

@pmclaren19 there's a merge conflict

@pmclaren19
Copy link
Contributor Author

@pmclaren19 there's a merge conflict

Yes I've updated it a few times haha at this point was waiting for a reviewer so I don't have to keep updating it every hour! Should be good to review again @stevenjcumming !

@pmclaren19 pmclaren19 merged commit 6d711cb into master Jan 16, 2025
22 checks passed
@pmclaren19 pmclaren19 deleted the 100037-Add-Evidence-Submission-Table branch January 16, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants