Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-42610-check-definitions-healthchecks #20232

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

stiehlrod
Copy link
Contributor

@stiehlrod stiehlrod commented Jan 10, 2025

Summary

  • Makes adjustments to ensure the definitions file and the ok computer health checks match.

Related issue(s)

Testing done

What areas of the site does it impact?

modified:   modules/claims_api/app/clients/claims_api/bgs_client/definitions.rb
modified:   modules/claims_api/config/initializers/okcomputer.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to API-42610-check-definitions-healthchecks/main/main January 10, 2025 17:43 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-42610-check-definitions-healthchecks/main/main January 10, 2025 18:03 Inactive
@stiehlrod stiehlrod marked this pull request as ready for review January 10, 2025 18:59
@stiehlrod stiehlrod requested a review from a team as a code owner January 10, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants