93461: Add #employment_history to VBA214140 #20231
Open
+220
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekhouck
commented
Jan 10, 2025
Comment on lines
+83
to
+85
| "F[0].#subform[1].Name_And_Address_Of_Employer[0]": "<%= form.employment_history[3].name_and_address %>", | ||
| "F[0].#subform[1].Name_And_Address_Of_Employer[1]": "<%= form.employment_history[2].name_and_address %>", | ||
| "F[0].#subform[1].Name_And_Address_Of_Employer[2]": "<%= form.employment_history[1].name_and_address %>", |
There was a problem hiding this comment.
Form mappings go from bottom of the page to the top for some reason, so all employers are iterated over in reverse order.
derekhouck
commented
Jan 10, 2025
Comment on lines
+111
to
+112
| "F[0].#subform[1].Gross_Earnings_Per_Month[0]": "<%= form.employment_history[2].highest_income %>", | ||
| "F[0].#subform[1].Gross_Earnings_Per_Month[1]": "<%= form.employment_history[3].highest_income %>", |
There was a problem hiding this comment.
These two fields are flipped on the PDF mapping, hence the odd ordering.
va-vfs-bot
temporarily deployed
to
93461-employment-history/main/main
derekhouck
changed the title
derekhouck
commented
Jan 10, 2025
Comment on lines
+33
to
+35
| def employed? | ||
| data['employers'] ? data['employers'].size.positive? : false | ||
| end |
There was a problem hiding this comment.
This method will be used in a later PR when we're figuring out where to put signatures and dates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#employment_historyand#employed?toVBA214140.FormEngine::EmploymentHistoryclass to handle employment history data.Related issue(s)
Testing done
FormEngine::EmploymentHistoryclass#employment_historyand#employed?instance methodsWhat areas of the site does it impact?
At the moment, none. It will ultimately impact the Simple Forms API, adding support for the 21-4140 form.
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?