Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API-43906-remove-deprec-services-IV #20229

Closed
wants to merge 1 commit into from
Closed

API-43906-remove-deprec-services-IV #20229

wants to merge 1 commit into from
+0 −165

Conversation

stiehlrod
Copy link
Contributor

Summary

  • Removes rswag v2/power_of_attorney_requests/decisions/create/rswag_spec

Related issue(s)

Testing Done

What areas of the site does it impact?

deleted:    modules/claims_api/spec/requests/v2/power_of_attorney_requests/decisions/create/rswag_spec.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

Please help to make sure we don't remove anything that we need. TY!

@stiehlrod stiehlrod self-assigned this Jan 10, 2025
@stiehlrod stiehlrod marked this pull request as ready for review January 10, 2025 15:36
@stiehlrod stiehlrod requested a review from a team as a code owner January 10, 2025 15:36
tycol7
tycol7 requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@tycol7 tycol7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we deleting this file? it generates docs for an endpoint under development.

@stiehlrod stiehlrod closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tycol7 tycol7 tycol7 requested changes

Assignees

@stiehlrod stiehlrod

Labels
claimsApi modules/claims_api omit-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stiehlrod @tycol7 @va-vfs-bot