Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: restore faraday version to 2.12 #20228

Merged
merged 1 commit into from
Jan 10, 2025
Merged

revert: restore faraday version to 2.12 #20228

merged 1 commit into from
Jan 10, 2025
+70 −29

Conversation

ericboehs
Copy link
Contributor

@ericboehs ericboehs commented Jan 10, 2025 •
edited
Loading

Original PR: #19978
Revert PR: #20141

This reverts a previous revert that downgraded the Faraday gem to version 2.10 due to test failures. We believe that was a false alarm and was actually just flaky tests.

@ericboehs
revert: restore faraday version to 2.12
bf92666 
Original PR: #19978
Revert PR: #20141

This reverts a previous commit that downgraded the Faraday gem to
version 2.10 due to test failures. We believe that was a false alarm and
was actually just flaky tests.
@ericboehs ericboehs marked this pull request as ready for review January 10, 2025 16:12
@ericboehs ericboehs requested review from a team as code owners January 10, 2025 16:12
@ericboehs ericboehs requested a review from aherzberg January 10, 2025 16:12
ryan-mcneil
ryan-mcneil approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@bosawt FYI we're trying again

@ericboehs ericboehs merged commit 4f29626 into master Jan 10, 2025
52 checks passed
@ericboehs ericboehs deleted the eb-upgrade-faraday-to-2-12 branch January 10, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosawt bosawt bosawt approved these changes

@ryan-mcneil ryan-mcneil ryan-mcneil approved these changes

@aherzberg aherzberg Awaiting requested review from aherzberg aherzberg is a code owner automatically assigned from department-of-veterans-affairs/mobile-api-team

Assignees
No one assigned
Labels
require-backend-approval test-failure test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ericboehs @ryan-mcneil @bosawt @va-vfs-bot