Always use mhv_user_account cached response on User

[rileyanderson]

Summary

• User#mhv_user_account will always use the cached version. If there is no cached version, it will return nil.

Related issue(s)

• https://jira.devops.va.gov/browse/VI-968

Testing

• make sure your local cache is enabled rails dev:cache
• Cache the mhv_user_account request for the user you will login with
  • start a rails server - rails s
  • in rails console - rails c:

    icn = 1012667122V019349 # change to the icn of the user you will login with (they need to have accepted TOU)
    
    user_account = User.find_by(icn:)
    user_verification = user_account.user_verifications.idme.first 
    
    MHV::UserAccount::Creator.new(user_verification:).perform

  • Check to make sure the response was cached

    cache_key = "mhv_account_creation_#{icn}"
    
    Rails.cache.read(cache_key)
    # => {:user_profile_id=>"12345678", :premium=>true, :champ_va=>true, :patient=>true, :sm_account_created=>true, :message=>"Existing MHV Account Found for ICN"} 

• Start vets-website and login
• go to http://localhost:3000/v0/user and copy uuid
• Find your user in the rails console and call mhv_user_account:

  user = User.find(uuid)
  
  user.mhv_user_account

  this should return the MHVUserAccount since it is cached and not make a call to MHV
• Delete response from cache and call user.mhv_user_account again, this should return nil and not make a call to MHV

  Rails.cache.delete(cache_key)
  
  user.mhv_user_account
  # => nil

What areas of the site does it impact?

User, mhv user account

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

[bosawt]

Is there a reason this doesn't return a MHVUserAccount?

[rileyanderson]

I changed it to explicitly return nil. if there is nothing in the cache and we only want to pull from the cache we return nil, otherwise we try to create an MHVUserAccount

[bosawt]

Confirmed user.mhv_correlation_id did not call service, and returned nil, until service was successfully called, and then returned account id after that