98355: Remove deprecated versions of DR sidekiq jobs

[dfong-adh]

Summary

This removes deprecated DR sidekiq jobs as DR engine versions of the same jobs are already running in their place.

This will not be merged until Jan 13 or later.

• This work is behind a feature toggle (flipper): YES/NO
  No

Related issue(s)

department-of-veterans-affairs/va.gov-team#98355

Testing done

Verified jobs were removed locally

What areas of the site does it impact?

Sidekiq jobs

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

1 Error

🚫

This PR changes 1767 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, those exceeding 500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into smaller ones. If you have reason to believe that this PR should be granted an exception, please see the Submitting pull requests for approval - FAQ. File Summary Files app/sidekiq/decision_review/delete_saved_claim_records_job.rb (+0/-22) app/sidekiq/decision_review/failure_notification_email_job.rb (+0/-183) app/sidekiq/decision_review/hlr_status_updater_job.rb (+0/-34) app/sidekiq/decision_review/nod_email_loader_job.rb (+0/-34) app/sidekiq/decision_review/nod_send_email_job.rb (+0/-20) app/sidekiq/decision_review/nod_status_updater_job.rb (+0/-37) app/sidekiq/decision_review/saved_claim_status_updater_job.rb (+0/-189) app/sidekiq/decision_review/sc_status_updater_job.rb (+0/-40) spec/sidekiq/decision_review/delete_saved_claim_records_job_spec.rb (+0/-86) spec/sidekiq/decision_review/failure_notification_email_job_spec.rb (+0/-516) spec/sidekiq/decision_review/hlr_status_updater_job_spec.rb (+0/-24) spec/sidekiq/decision_review/nod_email_loader_job_spec.rb (+0/-44) spec/sidekiq/decision_review/nod_send_email_job_spec.rb (+0/-38) spec/sidekiq/decision_review/nod_status_updater_job_spec.rb (+0/-25) spec/sidekiq/decision_review/sc_status_updater_job_spec.rb (+0/-162) spec/sidekiq/decision_review/shared_examples_for_status_updater_jobs.rb (+0/-313) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[shaunburdick]

LGTM

[LindseySaari]

@dfong-adh It looks like you may have forgotten to remove some of these jobs from the periodic job definitions

[shaunburdick]

@dfong-adh It looks like you may have forgotten to remove some of these jobs from the periodic job definitions

@LindseySaari This PR is deleting the old code as these were moved to a module. Those refer to the new module versions of the cron (Yeah, it's confusing in a PR without context. Sorry)